Message-ID: <4cdc292e-3234-a03d-107d-31cf8b721cd4@kimmet.dk>
Date: Sat, 8 Jul 2023 08:11:10 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH] Add support function for containment operators
To: pgsql-hackers@lists.postgresql.org
References: <94f64d1f-b8c0-b0c5-98bc-0793a34e0851@kimmet.dk>
 <4e6efd382b3195eb7ea438b7219cc94d9399c0bd.camel@cybertec.at>
 <147ac793f2c3a9a57764fba84988a4b5e843443b.camel@cybertec.at>
Content-Language: da
From: Kim Johan Andersson <kimjand@kimmet.dk>
In-Reply-To: <147ac793f2c3a9a57764fba84988a4b5e843443b.camel@cybertec.at>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/4cdc292e-3234-a03d-107d-31cf8b721cd4%40kimmet.dk>
Precedence: bulk

On 07-07-2023 13:20, Laurenz Albe wrote:
> I wrote:
>> You implement both "SupportRequestIndexCondition" and "SupportRequestSimplify",
>> but when I experimented, the former was never called.  That does not
>> surprise me, since any expression of the shape "expr <@ range constant"
>> can be simplified.  Is the "SupportRequestIndexCondition" branch dead code?
>> If not, do you have an example that triggers it?

I would think it is dead code, I came to the same conclusion. So we can 
drop SupportRequestIndexCondition, since the simplification happens to 
take care of everything.


> I had an idea about this:
> So far, you only consider constant ranges.  But if we have a STABLE range
> expression, you could use an index scan for "expr <@ range", for example
> Index Cond (expr >= lower(range) AND expr < upper(range)).
> 

I will try to look into this. Originally that was what I was hoping for, 
but didn't see way of going about it.

Thanks for your comments, I will also look at the locale-related 
breakage you spotted.

	Regards,
		Kimjand