Subject: Re: assorted code cleanup
To: Ryan Murphy <ryanfmurphy@gmail.com>, pgsql-hackers@postgresql.org
References: <2beab0ef-69f9-dab3-cacd-8fdf417bca96@2ndquadrant.com>
 <CA+TgmoZaA_wtvAq0V6G+0yViivakjbMyEDPah9Zgi7H9e6iW4Q@mail.gmail.com>
 <20170829073246.23546.85121.pgcf@coridan.postgresql.org>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <4cf1f89b-10d2-46b8-bd52-ed48e1ceb462@2ndquadrant.com>
Date: Tue, 5 Sep 2017 15:08:50 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)
 Gecko/20100101 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20170829073246.23546.85121.pgcf@coridan.postgresql.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 8/29/17 03:32, Ryan Murphy wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world:  tested, passed
> Implements feature:       tested, passed
> Spec compliant:           tested, passed
> Documentation:            tested, passed
> 
> I've reviewed the code changes, and it's pretty clear to me that they clean things up a bit while not changing any behavior.  They simplify things in a way that make the code more comprehensible.  I've run all the tests and they behave the same way as they did before the patch.  I also trying manually playing around the the function in question, `metaphone`, and it seems to behave the same as before.
> 
> I think it's ready to commit!
> 
> The new status of this patch is: Ready for Committer

Pushed, except the one with the function pointers, which some people
didn't like.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers