Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1gIZAl-0001uS-QO for pgsql-hackers@arkaria.postgresql.org; Fri, 02 Nov 2018 13:07:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gIZAj-0002x5-Vq for pgsql-hackers@arkaria.postgresql.org; Fri, 02 Nov 2018 13:07:33 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1gIZAj-0002wv-P5 for pgsql-hackers@lists.postgresql.org; Fri, 02 Nov 2018 13:07:33 +0000 Received: from mail-qk1-f194.google.com ([209.85.222.194]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gIZAf-0008P8-W5 for pgsql-hackers@postgresql.org; Fri, 02 Nov 2018 13:07:33 +0000 Received: by mail-qk1-f194.google.com with SMTP id d19so2872231qkg.5 for ; Fri, 02 Nov 2018 06:07:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from :organization:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=m5ZjuSOO9ekOz/GdB9ipeonjVX+YN0EF0Zgfhy3YQLE=; b=adxVvFaz3n5N9iwZ5lir6kwgJAvgcoy+zY+EKNn2cxLBuHnBKgQ8ezCZj3midQFOF3 R7bQJfkCjj41yZAvSSTVjsg4+oFJo5U/REIJZCKc3BHtEaLXgIMba3HopZAQsvxbzA1k To6VJyTcx6CVB/pIHhnxJDMjA5rnLOgexZWcpxNn6OE7r4WkAcQDHnMWSI0ALjVMSg0l 7TpdkmeuW5q1tEK8/zzHpjA9wjo57WD5TDPYKh8Al0X7a/WWnlQbEvic4alrK0atf7C3 38l4VgcVsKaVstxxX73Yo2F59cms+gxi9bHRLXQ4wMjUlI76oSyoVSMSwla9+PWSaFjp cwEQ== X-Gm-Message-State: AGRZ1gJnkZlRkI55nsmWsFj/aeAVhJ+WuzH1vK61DSldBI15V+YI+f8k uHbDvBjdmjKIxFRpQK0rk8CN3A== X-Google-Smtp-Source: AJdET5e12yRqHpGp4mIB1Ke+blNxAJfmQOW1QLnKI5AA2yQge85pZBexJP8CR2GFuMDnbmO1uwRQjg== X-Received: by 2002:a37:8e81:: with SMTP id q123mr5233917qkd.34.1541164047239; Fri, 02 Nov 2018 06:07:27 -0700 (PDT) Received: from localhost.localdomain (c-24-61-8-151.hsd1.ma.comcast.net. [24.61.8.151]) by smtp.gmail.com with ESMTPSA id p31sm15349505qkh.86.2018.11.02.06.07.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 02 Nov 2018 06:07:26 -0700 (PDT) Reply-To: jesper.pedersen@redhat.com Subject: Re: pread() and pwrite() To: Thomas Munro Cc: Tom Lane , Magnus Hagander , Oskari Saarenmaa , Pg Hackers , Tobias Oberstein References: <20180720081459.GC22214@saarenmaa.fi> <7f379440-dfec-70ca-8a0d-942f1381936b@redhat.com> <983a8d48-64fa-e2f7-55c4-41e20bc51ef5@redhat.com> <19344.1539050134@sss.pgh.pa.us> <21196.1539053390@sss.pgh.pa.us> <2145.1539058113@sss.pgh.pa.us> From: Jesper Pedersen Organization: Red Hat Message-ID: <4cf40b3d-96ed-7597-fb42-e5e29c5a40fe@redhat.com> Date: Fri, 2 Nov 2018 09:07:25 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Hi Thomas, On 10/9/18 4:56 PM, Thomas Munro wrote: > Thanks, much nicer. Rebased. > This still applies, and passes make check-world. I wonder what the commit policy is on this, if the Windows part isn't included. I read Heikki's comment [1] as it would be ok to commit benefiting all platforms that has pread/pwrite. The functions in [2] could be a follow-up patch as well. [1] https://www.postgresql.org/message-id/6cc7c8dd-29f9-7d75-d18a-99f19c076d10%40iki.fi [2] https://www.postgresql.org/message-id/c2f56d0a-cadd-3df1-ae48-b84dc8128c37%40redhat.com Best regards, Jesper