Subject: Re: logical replication launcher crash on buildfarm
To: Andres Freund <andres@anarazel.de>, Robert Haas <robertmhaas@gmail.com>
References: <20170316032833.2zxfnqe3sl3ktrbt@alap3.anarazel.de>
 <20170316034246.3uurliezczmka6cn@alap3.anarazel.de>
 <e56bda7f-9d29-6900-0f90-96be8219b930@2ndquadrant.com>
 <20170316085322.crffknkgee5s6air@alap3.anarazel.de>
 <368e64f6-ee9a-f09f-82b4-a33b61b28d36@2ndquadrant.com>
 <CA+TgmoZex1PWOSkFUJeA1SsyN8cy8AKsXfkHgpNRikahqyaEWw@mail.gmail.com>
 <20170316185505.mtztedkngd34z4i4@alap3.anarazel.de>
Cc: Petr Jelinek <petr.jelinek@2ndquadrant.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
 Petr Jelinek <petr@2ndquadrant.com>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <4d126046-3eee-b87c-b0e4-9506dae249db@2ndquadrant.com>
Date: Thu, 16 Mar 2017 23:24:07 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0)
 Gecko/20100101 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <20170316185505.mtztedkngd34z4i4@alap3.anarazel.de>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 3/16/17 14:55, Andres Freund wrote:
> I indeed think that's the right consequence.  One question is what to
> replace it with exactly - are we guaranteed we can dynamically lookup
> symbols by name in the main binary on every platform?

I think there is probably a way to do this on all platforms.  But it
seems that at least the Windows port of pg_dlopen would need to be
updated to support this.

> Alternatively we
> can just hardcode a bunch of bgw_function_name values that are matched
> to specific functions if bgw_library_name is NULL - I suspect that'd be
> the easiest / least worrysome portability-wise.

Basically a variant of fmgrtab, which addresses the same sort of problem.


-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers