Message-ID: <4d3cf783-514c-4bb6-ae58-4fc3f1fb1c3c@iki.fi>
Date: Mon, 6 Jul 2026 14:03:11 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: refactor ExecInitPartitionInfo
To: Haibo Yan <tristan.yim@gmail.com>, jian he <jian.universality@gmail.com>
Cc: Andreas Karlsson <andreas@proxel.se>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
References: 
 <CACJufxEN_mmgTtp-raJ9-VJHgyAGmb0SrO+01kn5by4mJ_XOfw@mail.gmail.com>
 <CACJufxGcUztOYcCj85o15YT68qPY3qpwUtdndqDgOs_Sps6Cow@mail.gmail.com>
 <de595a8e-2fc0-4931-94e5-3cb00d91d698@proxel.se>
 <CACJufxFX_pTuBnQKoDP56ChcRiYdN+54KZnf99vo7MqVWrXmYw@mail.gmail.com>
 <B56AF2C4-D60E-4D63-8DB7-011DF55903D4@gmail.com>
Content-Language: en-US
From: Heikki Linnakangas <hlinnaka@iki.fi>
In-Reply-To: <B56AF2C4-D60E-4D63-8DB7-011DF55903D4@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/4d3cf783-514c-4bb6-ae58-4fc3f1fb1c3c%40iki.fi>
Precedence: bulk

On 03/04/2026 01:19, Haibo Yan wrote:
>> On Apr 1, 2026, at 6:12 AM, jian he <jian.universality@gmail.com> wrote:
>> Ok. I switched it back to
>>
>> +    if (node &&
>> +        (node->withCheckOptionLists != NIL ||
>> +         node->returningLists != NIL ||
>> +         node->onConflictAction == ONCONFLICT_UPDATE ||
>> +         node->onConflictWhere ||
>> +         node->operation == CMD_MERGE))
>> +    {
>> +        /* later map_variable_attnos need use attribute map, build it 
>> now */
>> +        part_attmap = build_attrmap_by_name(RelationGetDescr(partrel),
>> + 
>>                                            RelationGetDescr(firstResultRel),
>> +                                            false);
>> +    }
>> +
>
> Hi Jian,
> 
> Thanks for working on this.
> 
> I’m not convinced this refactoring buys us much in its current form.

+1, for all the reasons you said. I have marked this as rejected in the 
commitfest app. Thanks!

- Heikki