Feedback-ID: i131946ab:Fastmail
Message-ID: <4d61a288-cc0a-cd79-2cd8-2019415be939@enterprisedb.com>
Date: Thu, 15 Dec 2022 10:32:27 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.5.1
Subject: Re: static assert cleanup
Content-Language: en-US
To: John Naylor <john.naylor@enterprisedb.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
References: <941a04e7-dd6f-c0e4-8cdf-a33b3338cbda@enterprisedb.com>
 <CAFBsxsGar4THO2VOj3UMAMq+Ns63eWoa0N94JWvW7FJ-N08TKg@mail.gmail.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: 
 <CAFBsxsGar4THO2VOj3UMAMq+Ns63eWoa0N94JWvW7FJ-N08TKg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/4d61a288-cc0a-cd79-2cd8-2019415be939%40enterprisedb.com>
Precedence: bulk

On 09.12.22 11:01, John Naylor wrote:
> 
> On Fri, Dec 9, 2022 at 2:47 PM Peter Eisentraut 
> <peter.eisentraut@enterprisedb.com 
> <mailto:peter.eisentraut@enterprisedb.com>> wrote:
>  >
>  > 0003-Move-some-static-assertions-to-better-places.patch
>  >
>  > This moves some that I thought were suboptimally placed but it could be
>  > debated or refined.
> 
> + * We really want ItemPointerData to be exactly 6 bytes.  This is rather a
> + * random place to check, but there is no better place.
> 
> Since the assert is no longer in a random function body, it seems we can 
> remove the second sentence.

Committed with the discussed adjustments.