Message-ID: <4d6c4e64-b4e5-e050-23f9-e960df8f434b@enterprisedb.com>
Date: Wed, 6 Apr 2022 10:37:29 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: psql - add SHOW_ALL_RESULTS option - pg_regress output
Content-Language: en-US
To: Andres Freund <andres@anarazel.de>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>,
 "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
References: <63350f81-6a43-f536-24e6-b30f48797732@enterprisedb.com>
 <alpine.DEB.2.22.394.2203231342180.3205455@pseudo>
 <ff1ea8cc-5938-477b-ac85-85e242c6eddf@enterprisedb.com>
 <alpine.DEB.2.22.394.2203251646020.3449922@pseudo>
 <alpine.DEB.2.22.394.2203261650010.3931183@pseudo>
 <alpine.DEB.2.22.394.2203311853340.1072349@pseudo>
 <alpine.DEB.2.22.394.2204010745570.1603090@pseudo>
 <9621d9b8-6e27-ba1a-069e-c44a0dd3a7ba@enterprisedb.com>
 <alpine.DEB.2.22.394.2204021524580.2117840@pseudo>
 <8441a96a-5db0-6f41-1d23-7018811e2c87@enterprisedb.com>
 <20220406020621.dfwvyuagy6tlc3fo@alap3.anarazel.de>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <20220406020621.dfwvyuagy6tlc3fo@alap3.anarazel.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/4d6c4e64-b4e5-e050-23f9-e960df8f434b%40enterprisedb.com>
Precedence: bulk

On 06.04.22 04:06, Andres Freund wrote:
> On 2022-04-04 23:32:50 +0200, Peter Eisentraut wrote:
>> This has been committed.
> 
> It's somewhat annoying that made pg_regress even more verbose than before:
> 
> ============== removing existing temp instance        ==============
> ============== creating temporary instance            ==============
> ============== initializing database system           ==============
> ============== starting postmaster                    ==============
> running on port 51696 with PID 2203449
> ============== creating database "regression"         ==============
> CREATE DATABASE
> ALTER DATABASE
> ALTER DATABASE
> ALTER DATABASE
> ALTER DATABASE
> ALTER DATABASE
> ALTER DATABASE
> ============== running regression test queries        ==============
> 
> Unfortunately it appears that neither can CREATE DATABASE set GUCs, nor can
> ALTER DATABASE set multiple GUCs in one statement.
> 
> Perhaps we can just set SHOW_ALL_RESULTS off for that psql command?

Do you mean the extra "ALTER DATABASE" lines?  Couldn't we just turn all 
of those off?  AFAICT, no one likes them.