Message-ID: <4e7a71b5-1c7e-48bf-909a-aee5a413fa97@oss.nttdata.com>
Date: Tue, 15 Jul 2025 19:07:16 +0900
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Extend ALTER DEFAULT PRIVILEGES for large objects
To: Yugo Nagata <nagata@sraoss.co.jp>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>,
 Nathan Bossart <nathandbossart@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
 pgsql-hackers@postgresql.org
References: <20240424115242.236b499b2bed5b7a27f7a418@sraoss.co.jp>
 <20240424210839.GA863220@nathanxps13>
 <20240426175406.13e47ea3904de814afbfe496@sraoss.co.jp>
 <20240913161801.b1e60534d77fa9df447b775f@sraoss.co.jp>
 <9c0c4d7881d2450baf70edb0ae95415a81ac8cb1.camel@cybertec.at>
 <20250123192220.9bad2b9aec110bf335521276@sraoss.co.jp>
 <fb552452-d61f-403b-85c1-187ea7f030af@oss.nttdata.com>
 <20250403230418.f41b23d155f6c6cb3cebcd92@sraoss.co.jp>
 <dfa9a1fc-1570-45a0-8735-57c414629cec@oss.nttdata.com>
 <ade0ab29-777f-47f6-9d0d-1af67728a86e@oss.nttdata.com>
 <20250408122857.b2b06dde4e6a08290af02336@sraoss.co.jp>
 <20250611114937.b067c542192f8e5e740a2a4a@sraoss.co.jp>
 <b448cc01-ce8d-45f3-a922-c63490bbdec4@oss.nttdata.com>
 <20250611135737.bb7d3135141248819704ebca@sraoss.co.jp>
 <a09986e3-958c-4151-8244-f43c28701ddf@oss.nttdata.com>
 <20250710103041.f93be994017e4ab61b9b9c35@sraoss.co.jp>
 <610c7506-3cd2-41c6-8346-581d120cf841@oss.nttdata.com>
 <20250710141129.94cb58f465e706fa37c1b9d2@sraoss.co.jp>
Content-Language: en-US
From: Fujii Masao <masao.fujii@oss.nttdata.com>
In-Reply-To: <20250710141129.94cb58f465e706fa37c1b9d2@sraoss.co.jp>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/4e7a71b5-1c7e-48bf-909a-aee5a413fa97%40oss.nttdata.com>
Precedence: bulk


On 2025/07/10 14:11, Yugo Nagata wrote:
> On Thu, 10 Jul 2025 13:23:47 +0900
> Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
> 
>>
>>
>> On 2025/07/10 10:30, Yugo Nagata wrote:
>>> You're right. I must have overlooked something. I think I saw "TO" being
>>> suggested after "FOREIGN SERVER" when no foreign servers were defined.
>>>
>>> The attached patch still prevents "TO/FROM" from being suggested after
>>> "FOREIGN SERVER" in such cases.
> 
>>
>> Based on your patch, I'm thinking of simplifying the code like this:
>>
>> -       else if (Matches("GRANT", MatchAnyN, "ON", MatchAny, MatchAny))
>> -               COMPLETE_WITH("TO");
>> -       else if (Matches("REVOKE", MatchAnyN, "ON", MatchAny, MatchAny))
>> -               COMPLETE_WITH("FROM");
>> +       else if (Matches("GRANT|REVOKE", MatchAnyN, "ON", MatchAny, MatchAny) &&
>> +                        !TailMatches("FOREIGN", "SERVER") && !TailMatches("LARGE", "OBJECT"))
>> +       {
>> +               if (Matches("GRANT", MatchAnyN, "ON", MatchAny, MatchAny))
>> +                       COMPLETE_WITH("TO");
>> +               else
>> +                       COMPLETE_WITH("FROM");
>> +       }
> 
> Thank you for your review!
>   I agree with your suggestion and have updated the patch accordingly.

I've pushed the patch. Thanks!

>>> But perhaps this corner case doesn't really
>>> need to be handled?
>>
>> Probably I failed to get your point here. Could you clarify what you meant?
> 
> I'm sorry for not explaining it clearly.
> 
> Currently, TO or FROM could be suggested immediately after FOREIGN SERVER, but
> only when no foreign servers are defined. When foreign servers do exist,
> their names are correctly suggested instead, as expected.
> 
> The patch fixed the behavior so that TO or FROM are not suggested after FOREIGN SERVER,
> even when no foreign servers are defined. However, I've started to wonder if it's worth
> fixing such a corner case. What do you think?

I think it's worth doing. This issue can lead to unexpected behavior
and is something users might run into. If the fix were overly complex
for a minor issue, it might not be justified. But that's not the case here.

Regards,

-- 
Fujii Masao
NTT DATA Japan Corporation