Feedback-ID: ie0a040ee:Fastmail
Message-ID: <4e82f77b-acad-4356-94f6-8255135fb36b@eisentraut.org>
Date: Tue, 20 Jan 2026 17:28:00 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Make copyObject work in C++
To: Jelte Fennema-Nio <postgres@jeltef.nl>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Thomas Munro <thomas.munro@gmail.com>
References: <CAGECzQR21OnnKiZO_1rLWO0-16kg1JBxnVq-wymYW0-_1cUNtg@mail.gmail.com>
 <4d8b9e53-3f37-43f0-a4aa-5bda9c7961b3@eisentraut.org>
 <DFEUMBSUG8KA.XGY0CN9PFPR2@jeltef.nl> <DFKV26A4CHG2.CB7NJ1X62BKH@jeltef.nl>
 <fd1a4790-4fbc-43b4-a385-e3b98b9ed04d@eisentraut.org>
 <DFQYWIJD4L1J.3HQFOWSWKLFOR@jeltef.nl>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <DFQYWIJD4L1J.3HQFOWSWKLFOR@jeltef.nl>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/4e82f77b-acad-4356-94f6-8255135fb36b%40eisentraut.org>
Precedence: bulk

On 17.01.26 16:25, Jelte Fennema-Nio wrote:
>> AFAICT, the minimum changes to get a minimum test module to work are
>>
>> - fix for "restrict", recently committed
>> - disable warning about zero-length arrays, seems trivial
>> - named designated initializers
> 
> Correct, I've now restructured the commits to have the module
> introduction as the first one. Then all the other commits, both fix a
> macro to work in C++ and add some usage of those macros as coverage to
> the previously added module.

I have split your first patch further.  For a start, I left out the 
PG_MODULE_MAGIC*-related changes and disabled the module under MSVC. 
This has been committed.  I plan to let the buildfarm run with it for a 
day or two and then add in the basic MSVC support.

I implemented a different solution for checking whether C++ is available 
under configure.  The runtime check from the makefile looked a bit 
fragile.  This way, we now have a "have_cxx" variable available in both 
meson and makefiles.