Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k900T-0002i0-AW for pgsql-hackers@arkaria.postgresql.org; Fri, 21 Aug 2020 05:54:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1k900Q-0005f9-7l for pgsql-hackers@arkaria.postgresql.org; Fri, 21 Aug 2020 05:54:26 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k900P-0005f2-9f for pgsql-hackers@lists.postgresql.org; Fri, 21 Aug 2020 05:54:25 +0000 Received: from mail.dalibo.com ([212.85.157.172]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k900H-0001Pm-Vu for pgsql-hackers@lists.postgresql.org; Fri, 21 Aug 2020 05:54:23 +0000 Received: from [192.168.0.10] (91-165-40-181.subs.proxad.net [91.165.40.181]) by mail.dalibo.com (Postfix) with ESMTPSA id 57AB12231A; Fri, 21 Aug 2020 07:54:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=dalibo.com; s=a; t=1597989254; bh=EiPGyBoALIK38NNp35IVdJymu2GDtdAN/rmYV5m7hmg=; h=Subject:To:References:From:Date:In-Reply-To:From; b=J8WDZAvQJEIvFJ4zCGh8x8VAKy/zp+acxm+JlP/3ku1lR//gkEkjCiY/dY5RC/yxp zuSb+cLJEa+n5iJWacFD2rvV7vJqEbfGuOmoXa2ftUSYNF6WyF2h6chbqKVfxTc+NV icdyJL+VLxIhPo8Ul81VKdgH5TpAZpqp6kQVZryc= Subject: Re: [PG13] Planning (time + buffers) data structure in explain plan (format text) To: pgsql-hackers@lists.postgresql.org, depesz@depesz.com, depesz@gmail.com References: <07b226e6-fa49-687f-b110-b7c37572f69e@dalibo.com> <20200819032706.GQ17022@telsasoft.com> <20200819072133.jnmtux7qbyxywh6r@nol> <20200819090429.s7hoyyw4a6jumgkc@nol> <5605ac79-90c0-6a5f-256d-5cabf52a3fe8@oss.nttdata.com> <0d074a53-fd91-b1dd-a529-173d07627465@oss.nttdata.com> From: Pierre Giraud Message-ID: <4e932e5e-8d86-4dcd-632e-f7c6e2c35a83@dalibo.com> Date: Fri, 21 Aug 2020 07:54:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <0d074a53-fd91-b1dd-a529-173d07627465@oss.nttdata.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Le 20/08/2020 à 17:41, Fujii Masao a écrit : > > > On 2020/08/20 22:34, Julien Rouhaud wrote: >> On Thu, Aug 20, 2020 at 12:29 PM David Rowley >> wrote: >>> >>> On Thu, 20 Aug 2020 at 19:58, Fujii Masao >>> wrote: >>>> >>>> On 2020/08/20 13:00, David Rowley wrote: >>>>> I forgot to mention earlier, you'll also need to remove the part in >>>>> the docs that mentions BUFFERS requires ANALYZE. >>>> >>>> Thanks for the review! I removed that. >>>> Attached is the updated version of the patch. >>>> I also added the regression test performing "explain (buffers on)" >>>> without "analyze" option. >>> >>> Looks good to me. >> >> Looks good to me too. > > David and Julien, thanks for the review! I'd like to wait for > Pierre's opinion about this change before committing the patch. > > Pierre, > could you share your opinion about this change? It looks good to me too. Thanks a lot! Let's not forget to notify Hubert (depesz) once integrated. > > Regards, >