Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tkgkH-005ywh-0v for pgsql-hackers@arkaria.postgresql.org; Wed, 19 Feb 2025 09:51:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tkgkF-006Xe3-G6 for pgsql-hackers@arkaria.postgresql.org; Wed, 19 Feb 2025 09:51:55 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tkgkF-006Xd9-0B for pgsql-hackers@lists.postgresql.org; Wed, 19 Feb 2025 09:51:55 +0000 Received: from mail1.dalibo.net ([51.159.93.128] helo=mail.dalibo.com) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tkgkD-001gfw-1D for pgsql-hackers@postgresql.org; Wed, 19 Feb 2025 09:51:54 +0000 Received: from [192.168.1.18] (unknown [90.58.191.166]) by mail.dalibo.com (Postfix) with ESMTPSA id 27E6C27E05; Wed, 19 Feb 2025 10:51:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=dalibo.com; s=a; t=1739958710; bh=r9mfiR9Iqhpl1Uu8VnaRqmDNRp6syEtHy5daFcurRBs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=gEbkMk4IoZRarm0psAf0R2rZVXHiISXTlS1X0F7Xxz7rVwxZqUh10K1czAkwgRL6F RLewOH27JLVQKQnXqXT2NU/d4MHnObzGG8SFYEDQMh1o3ytsaJunGyvPL5eKA3Lgwc dTDT7fcQqHddlDxaMAQOOEF4VLpCc9QpXz134tgg= Message-ID: <4ed10bc8-5513-4d8e-8643-8abcaa08336d@dalibo.com> Date: Wed, 19 Feb 2025 10:51:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Fix logging for invalid recovery timeline To: David Steele , "Andrey M. Borodin" Cc: Pg Hackers References: Content-Language: fr From: =?UTF-8?Q?Benoit_Lobr=C3=A9au?= Autocrypt: addr=benoit.lobreau@dalibo.com; keydata= xsBNBF3FR7IBCADDvtR0p09SI9OvnbWw+VEvO5IXefBWFWefxrPd0H3Sf3gsBLiKbRdkSjvz 2y+ksRgBUkhK1Kiqe/QuddgvuT9OUFBCrOtZxkBgJYRbxBNTOnIehhEoK9sdqjwvwNyxJUEX er1UgErP+MJTvwpW1J8Uq9oV+NbqgNQ7ca5G2D3x7DI2Tbbw0iu+lmCIdXQpTk7hacErGscC p/eaJQFd6EPAZPS7BQEgjuDDjGCy4RzTSiobtqn0ocaEj+w7365FVKKZD2LjEm1mfBK/4nml H/vlssXkKKpUGetaib6AVpZK3a0xBTMi04ft/V8iGGJuVhE45WjjKSckmeLafTZCGxN9ABEB AAHNK0Jlbm9pdCBMb2Jyw6lhdSA8YmVub2l0LmxvYnJlYXVAZGFsaWJvLmNvbT7CwJQEEwEI AD4CGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AWIQRkbHJAht3VPY+ptaDDJY+vq0O76wUC Za56QgUJC6uZkAAKCRDDJY+vq0O760ECCACDPj6p9VXaX4GF9p+3zhoDwxsUWh0xODwsK//h SBGsRmPaElApbOR5rs2WDFaPE95XG3Vdo2rno7i4mt0fASls7vq4P0BPJiPM4fKEr+kfXAxP 2clqmkBMn2o+EEeUGDmnn3RAVzDDoyML6N/unpyOTHWfscxvvj6AKreUtxzQm0LVQRL+hIaG SAlcwpVWQBPhA6Roi1/7Uz9qm8nWjFOuV6vO5yVe0sfRrrO9AFkjBGFT/B06sSs33Os6Hjs5 2ckLn5Gxlty8XgTpbaG0bJiV+GDTcXh5UV8XVKaMomOLJxWw8US6PSSqQxodWuJqsvlxXV93 ae6cMIosHsriaUo5zsBNBF3FR7IBCADEWwsQar1qtLKdoAoqKThz+kQXu3UADQ0c8JCgsp+8 a6hFDg+uIw0j852lkJOPHll414Qw+kLC1bUo7H6+mPHzko/aR3TFz6vvOrm0afwFP7sm9Vbe UbpeohnrXBBwb1PjNhDphaXeMVovJqSgRifhc/sAR6fXi+2OCrH+8CUYa0aHhwoecStgw/tm EDPZ8lCsg5IdyO5Er4ZMOl/EbaRuTOpl7U/GzJBQSYf7t4KHotIpEeuJVv4X/+nTW3ALG+dG pRA5GplNnlQNfsEymnT4W7RbfafDp7Q7nK6w7d55ZU8UyiS6N/1wh/DL1hntC65lQbHlmwNx RG132ecNOcqFABEBAAHCwHwEGAEIACYCGwwWIQRkbHJAht3VPY+ptaDDJY+vq0O76wUCZa56 dQUJC6uZwwAKCRDDJY+vq0O76y9jB/0fVyz7D56D2A6MUGASNkh6IiuHCF/UgEfU0m5fC6pd 38+fmyUMkGR3QwrtZP3SCLaBKT4LHxhVu7tEUWI+6WK7/s0Jsx5L8aIfDKY4zjqQ9InP+LkA azkKW4JpIb9Ny0FzRjUyf9gReU5nMy9sUNS4DhoHG6c/bQYqkj9uA5AokiDDCRg2dobfpaNP C6qQQIXD+wi0aZ4jR5r4rXMxmwFutandoaxDpPBj4EXlyRHhzyKfgb2c6TXdCVQ5YJUFUi9k gl7CXplN8vBpMuzN5y6NPd3Xekcp16D5XCQNBQ2drIsnFR4IbDPI1Mqd6OJYH0vum6g8FmoN s7ygc4oi12nU In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, I think the changes make sense. Would it be helpful to add the origin of the checkpoint record we are referring to ? (i.e. control file or backup label). For example: * Latest checkpoint in the control file is at %X/%X on timeline %u, * Checkpoint location in the backup_label file is at %X/%X on timeline %u, The current message refers to "Latest checkpoint" which automatically makes me think about the control file (specifically, the pg_controldata output). Now that I have read the code, I understand which one we are referring to, but for someone who hasn't (or me in a few month) it might be useful ? -- Benoit Lobréau Consultant http://dalibo.com