Subject: Re: remove some STATUS_* symbols
To: Michael Paquier <michael@paquier.xyz>
References: <a6f91ead-0ce4-2a34-062b-7ab9813ea308@2ndquadrant.com>
 <20200106063159.GQ3598@paquier.xyz>
 <eb176922-2b1f-86d1-9ed4-e2c60a39b956@2ndquadrant.com>
 <20200110052332.GI1702@paquier.xyz>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <4edc8a92-373c-1a4d-eded-6b342f0890dc@2ndquadrant.com>
Date: Sat, 11 Jan 2020 08:14:17 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20200110052332.GI1702@paquier.xyz>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2020-01-10 06:23, Michael Paquier wrote:
> On Thu, Jan 09, 2020 at 11:15:08AM +0100, Peter Eisentraut wrote:
>> You mean put he subsequent GrantLock() calls into LockCheckConflicts()? That
>> would technically save some duplicate code, but it seems weird, because
>> LockCheckConflicts() is notionally a read-only function that shouldn't
>> change state.
> 
> Nah.  I was thinking about the first part of this "if" clause
> LockCheckConflicts is part of here:
>     if (lockMethodTable->conflictTab[lockmode] & lock->waitMask)
>         status = STATUS_FOUND;
>     else
>         status = LockCheckConflicts(lockMethodTable, lockmode,
>                                     lock, proclock);
> 
> But now that I look at it closely it messes up heavily with
> ProcSleep() ;)

OK, pushed as it was then.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services