Message-ID: <4efc426cde8eed9734af3a4552c3be29188f3661.camel@j-davis.com>
Subject: Re: pg_get__*_ddl consolidation
From: Jeff Davis <pgsql@j-davis.com>
To: Andrew Dunstan <andrew@dunslane.net>, "David G. Johnston"
	 <david.g.johnston@gmail.com>, Japin Li <japinli@hotmail.com>
Cc: Zsolt Parragi <zsolt.parragi@percona.com>, Euler Taveira
 <euler@eulerto.com>,  =?ISO-8859-1?Q?=C1lvaro?= Herrera
 <alvherre@kurilemu.de>, PostgreSQL Hackers
 <pgsql-hackers@lists.postgresql.org>
Date: Fri, 10 Apr 2026 13:03:36 -0700
In-Reply-To: <a1c4dd3e-6694-4b7b-8432-f3b584735ff3@dunslane.net>
References: <202603201311.yhtqmvektawm@alvherre.pgsql>
	 <bf49721a-a56f-4bdc-ac48-5d4dc1d01805@dunslane.net>
	 <8ec9b67d-939e-4b22-8d56-a5129f92d32d@app.fastmail.com>
	 <CAN4CZFNYM5jNA_gLu9miAXg_7c8Z2zf-ePc+0rzidAV3CBs=cw@mail.gmail.com>
	 <555cdee4-c024-4872-9d96-82ef4216239c@dunslane.net>
	 <SY7PR01MB10921A6E1E08A48F3426FE529B651A@SY7PR01MB10921.ausprd01.prod.outlook.com>
	 <CAKFQuwYcppypeGBwa7ZbDAfoUXSv+kLhJuAXsdwBmKrvy8wDFw@mail.gmail.com>
	 <a533fb1b-0f2c-4fc9-ab3b-6fb5ddac1800@dunslane.net>
	 <a1c4dd3e-6694-4b7b-8432-f3b584735ff3@dunslane.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.3-0ubuntu1.1 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/4efc426cde8eed9734af3a4552c3be29188f3661.camel%40j-davis.com>
Precedence: bulk

On Sun, 2026-04-05 at 11:06 -0400, Andrew Dunstan wrote:
> Pushed. I have moved the remaining get_*_ddl items to PG20-1

The line:

  role_settings =3D DatumGetArrayTypeP(datum);

should be DatumGetArrayTypePCopy(), because it's being pfree()d later.
The existing code will sometimes make a copy and sometimes not, e.g.:

  -- settings are contrived to make the datum inline
  CREATE USER u1;
  ALTER ROLE u1 SET search_path =3D 'public, pg_catalog, pg_temp';
  ALTER ROLE u1 SET work_mem=3D'64MB';
  ALTER ROLE u1 SET statement_timeout=3D'30s';
  ALTER ROLE u1 SET lock_timeout=3D'10s';
  ALTER ROLE u1 SET idle_in_transaction_session_timeout =3D '60s';
  SELECT pg_get_role_ddl('u1');
  ERROR:  pfree called with invalid pointer 0x7986dd0c7cc8 (header
0x0000400600000000)

Also, it looks like the scan key in pg_get_role_ddl_internal() uses
only the second attribute of the index, which might be worth a comment.

Regards,
	Jeff Davis