Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cqn5V-0000MI-0o for pgsql-hackers@arkaria.postgresql.org; Wed, 22 Mar 2017 20:42:33 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cqn5U-0004Ho-6m for pgsql-hackers@arkaria.postgresql.org; Wed, 22 Mar 2017 20:42:32 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cqn5T-0004Hf-2u for pgsql-hackers@postgresql.org; Wed, 22 Mar 2017 20:42:31 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cqn5M-0000Zv-5i for pgsql-hackers@postgresql.org; Wed, 22 Mar 2017 20:42:29 +0000 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 4B877209CE; Wed, 22 Mar 2017 16:42:23 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute7.internal (MEProxy); Wed, 22 Mar 2017 16:42:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=apjn0WZNaeD9unHw9LciQzmUw5bUd+rNs8ivWu1vV5w=; b=d0/ML6KV OuHeilVpXG+sOqtNZRFUvB4u6v5PnJzAx9matRdJUW//OpzU52CZRBZ1pFGDRUzf xMeSQb0K1xxGQz1GerMWnWN7Jcktx6E9ERX6qr6gfjiLb7khAAR2Lb/36B9EE4v/ rdHp/GWVOe3x7+Dn9Xj3eX0ABfwt6Rb0IyP/VXVOl6Sd8MDHq6JrOkwfeV4sXs/V 8b+aUeKAn8m8N/IIZR7qb91aQ8ZHzYkHdleoXoUfnNiqwpRZXnRBcwUQ5nvHS39R BNTY8TmqnOCbF3HKQg6BJskYYcbew8EBCuAcU9U9F21QOGAcEZ0ZkETOOOe6yn2L FCXiUweg9j2vzQ== X-ME-Sender: X-Sasl-enc: 59uhoGzg17Ry3ZEhE2OvOi/IbFi5lrZCAmEBVSA3t0ho 1490215343 Received: from april.local (c-73-13-66-39.hsd1.pa.comcast.net [73.13.66.39]) by mail.messagingengine.com (Postfix) with ESMTPA id F2B777E669; Wed, 22 Mar 2017 16:42:22 -0400 (EDT) Subject: Re: PATCH: Make pg_stop_backup() archive wait optional To: Stephen Frost , Fujii Masao References: <081cbf08-35c1-4580-8c31-3ae70b507fb1@pgmasters.net> <0A3221C70F24FB45833433255569204D1F6B3F95@G01JPEXMBYT05> <0A3221C70F24FB45833433255569204D1F6B5134@G01JPEXMBYT05> <49d70e8e-33bf-2390-e717-ba9562621aa4@pgmasters.net> <0A3221C70F24FB45833433255569204D1F6B607B@G01JPEXMBYT05> <20170322153703.GK9812@tamriel.snowman.net> <20170322191451.GY9812@tamriel.snowman.net> Cc: David Steele , "Tsunakawa, Takayuki" , Michael Paquier , Pg Hackers From: Peter Eisentraut Organization: 2ndQuadrant Message-ID: <4f41afe5-0947-ce53-e985-971bc774169b@2ndquadrant.com> Date: Wed, 22 Mar 2017 16:42:22 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170322191451.GY9812@tamriel.snowman.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On 3/22/17 15:14, Stephen Frost wrote: >> -SELECT * FROM pg_stop_backup(false); >> +SELECT * FROM pg_stop_backup(false [, true ]); >> >> I think that it's better to get rid of "[" and "]" from the above because >> IMO this should be the command example that users actually can run. > Using the '[' and ']' are how all of the optional arguments are > specified in the documentation, see things like current_setting() in our > existing documentation: In the synopsis, but not in concrete examples. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers