Message-ID: <4f4c04c2-f23c-6668-1b24-224fc6478bfd@enterprisedb.com>
Date: Thu, 24 Feb 2022 00:21:36 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.0
Subject: Re: convert libpq uri-regress tests to tap test
Content-Language: en-US
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org
References: <20220223203031.ezrd73ohvjgfksow@alap3.anarazel.de>
 <ffe496e6-11ba-6f60-1621-90a600335cec@enterprisedb.com>
 <1261838.1645657117@sss.pgh.pa.us>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <1261838.1645657117@sss.pgh.pa.us>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/4f4c04c2-f23c-6668-1b24-224fc6478bfd%40enterprisedb.com>
Precedence: bulk

On 23.02.22 23:58, Tom Lane wrote:
> Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
>> On 23.02.22 21:30, Andres Freund wrote:
>>> Where would we want that test to live? Right now we have the slightly odd
>>> convention that some tap tests live in src/test/{misc,modules,...}. But
>>> e.g. frontend binary ones are below src/bin/.
> 
>> libpq TAP tests should be in src/interfaces/libpq/t/.
> 
>> I think there were issues that the build farm wouldn't pick up a test
>> located there, but that should be fixed rather than worked around.
> 
> That's failing to account for the fact that a libpq test can't
> really be a pure-perl TAP test; you need some C code to drive the
> library.  I don't agree with intermixing such code with libpq
> itself, independently of any buildsystem issues (which there
> might well be).

Such things could be put under src/interfaces/libpq/test, or some other 
subdirectory.  We already have src/interfaces/ecpg/test.

> So I think the design of putting such tests under
> src/modules is fine.

I don't get what the rationale for that would be.  libpq tests are not 
"modules" of any kind.

If I'm working on libpq, I want to do make && make check inside the 
libpq source directory.