Feedback-ID: i131946ab:Fastmail
Message-ID: <4f66de67-35a0-3fe7-fa61-d618e1bd2c2c@enterprisedb.com>
Date: Wed, 5 Oct 2022 19:55:58 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.0
Subject: Re: archive modules
Content-Language: en-US
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, =?UTF-8?Q?Benoit_Lobr=c3=a9au?=
 <benoit.lobreau@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>,
 Robert Haas <robertmhaas@gmail.com>, "Bossart, Nathan"
 <bossartn@amazon.com>, David Steele <david@pgmasters.net>,
 Fujii Masao <masao.fujii@oss.nttdata.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
 Michael Paquier <michael@paquier.xyz>, Magnus Hagander
 <magnus@hagander.net>, Stephen Frost <sfrost@snowman.net>
References: <613541.1662842656@sss.pgh.pa.us>
 <20220910211046.GA2651323@nathanxps13>
 <9ee5d180-2c32-a1ca-d3d7-63a723f68d9a@enterprisedb.com>
 <20220914200305.GA2984249@nathanxps13>
 <37857474-5caa-ccb3-92a3-150ddfe851ab@enterprisedb.com>
 <2884265.1663188443@sss.pgh.pa.us> <20220914211746.GA2986134@nathanxps13>
 <2910705.1663193529@sss.pgh.pa.us> <20220914222736.GA3042279@nathanxps13>
 <d9d1f7fd-dd99-98f9-8aed-0e976921573b@enterprisedb.com>
 <20220923161402.GA736566@nathanxps13>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <20220923161402.GA736566@nathanxps13>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/4f66de67-35a0-3fe7-fa61-d618e1bd2c2c%40enterprisedb.com>
Precedence: bulk

On 23.09.22 18:14, Nathan Bossart wrote:
> On Fri, Sep 23, 2022 at 05:58:42AM -0400, Peter Eisentraut wrote:
>> On 15.09.22 00:27, Nathan Bossart wrote:
>>> Both archive_command and archive_library are PGC_SIGHUP, so IIUC that
>>> wouldn't be sufficient.  I attached a quick sketch that seems to provide
>>> the desired behavior.  It's nowhere near committable yet, but it
>>> demonstrates what I'm thinking.
>>
>> What is the effect of issuing a warning like in this patch?  Would it just
>> not archive anything until the configuration is fixed?  I'm not sure what
>> behavior you are going for; it's a bit hard to imagine from just reading the
>> patch.
> 
> Yes, it will halt archiving and emit a WARNING, just like what happens on
> released versions when you leave archive_command empty.

Leaving archive_command empty is an intentional configuration choice.

What we are talking about here is, arguably, a misconfiguration, so it 
should result in an error.