Content-Type: multipart/mixed; boundary="------------lZCrN8dAhCGCN9k0WXw0TB3t"
Message-ID: <4f79be75-7e30-4817-b0da-4a691ea5427f@postgrespro.ru>
Date: Mon, 23 Oct 2023 13:17:42 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: WIP: new system catalog pg_wait_event
Content-Language: en-US, ru-RU
To: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>,
 Michael Paquier <michael@paquier.xyz>
Cc: Masahiro Ikeda <ikedamsh@oss.nttdata.com>,
 Kyotaro Horiguchi <horikyota.ntt@gmail.com>, tgl@sss.pgh.pa.us,
 pgsql-hackers@lists.postgresql.org
References: <ZNxrMdmgrlovw1qD@paquier.xyz>
 <f2204399-cfdb-40e7-9479-9373ec6ba0ab@gmail.com>
 <735fbd560ae914c96faaa23cc8d9a118@oss.nttdata.com>
 <d28ad85d-1deb-4648-92a0-f38273fc91ca@gmail.com>
 <393fe340ab6980f399402a7dfbe13c4c@oss.nttdata.com>
 <0159e907-890d-4f11-8754-0311d7027bb7@gmail.com>
 <ZN9IZ2b7AdDZKSn/@paquier.xyz>
 <4fb03626-79aa-4c10-a002-2e5b71e65d22@gmail.com>
 <ZOCSpcueqMduuJJ5@paquier.xyz>
 <6f507a90-55db-4804-b360-eea4170d15fb@gmail.com>
 <ZOHJvk3x980Cc3ss@paquier.xyz>
 <1e0e03a5-1aee-44d9-b409-081afc142603@gmail.com>
From: Pavel Luzanov <p.luzanov@postgrespro.ru>
In-Reply-To: <1e0e03a5-1aee-44d9-b409-081afc142603@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/4f79be75-7e30-4817-b0da-4a691ea5427f%40postgrespro.ru>
Precedence: bulk

This is a multi-part message in MIME format.
--------------lZCrN8dAhCGCN9k0WXw0TB3t
Content-Type: multipart/alternative;
 boundary="------------5USoh6xJXAA1TgH2wF0kU7I6"

--------------5USoh6xJXAA1TgH2wF0kU7I6
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Please, consider this small fix for the query example in the docs[1]:

SELECT a.pid, a.wait_event, w.description
   FROM pg_stat_activity a JOIN
        pg_wait_events w ON (a.wait_event_type = w.type AND
                             a.wait_event = w.name)
   WHERE wait_event is NOT NULL and a.state = 'active';

I propose to add a table alias for the wait_event column in the WHERE clause for consistency.

1.https://www.postgresql.org/docs/devel/monitoring-stats.html#MONITORING-PG-STAT-ACTIVITY-VIEW

-- 
Pavel Luzanov
Postgres Professional:https://postgrespro.com

--------------5USoh6xJXAA1TgH2wF0kU7I6
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 7bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <pre>Please, consider this small fix for the query example in the docs[1]:</pre>
    <pre>SELECT a.pid, a.wait_event, w.description
  FROM pg_stat_activity a JOIN
       pg_wait_events w ON (a.wait_event_type = w.type AND
                            a.wait_event = w.name)
  WHERE wait_event is NOT NULL and a.state = 'active';

I propose to add a table alias for the wait_event column in the WHERE clause for consistency.

1. <a class="moz-txt-link-freetext" href="https://www.postgresql.org/docs/devel/monitoring-stats.html#MONITORING-PG-STAT-ACTIVITY-VIEW">https://www.postgresql.org/docs/devel/monitoring-stats.html#MONITORING-PG-STAT-ACTIVITY-VIEW</a>
</pre>
    <pre class="moz-signature" cols="72">-- 
Pavel Luzanov
Postgres Professional: <a class="moz-txt-link-freetext" href="https://postgrespro.com">https://postgrespro.com</a></pre>
  </body>
</html>

--------------5USoh6xJXAA1TgH2wF0kU7I6--

--------------lZCrN8dAhCGCN9k0WXw0TB3t
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-Fix-pg_wait_events-usage-example.patch"
Content-Disposition: attachment;
 filename="0001-Fix-pg_wait_events-usage-example.patch"
Content-Transfer-Encoding: base64

RnJvbSA2NGU5YWE4ZGRkZTM5MmI5N2JmZjY2ZDUzYTVkMDllMGE4MjAzODBjIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXZlbCBMdXphbm92IDxwLmx1emFub3ZAcG9zdGdy
ZXNwcm8ucnU+CkRhdGU6IE1vbiwgMjMgT2N0IDIwMjMgMTM6MDA6MTYgKzAzMDAKU3ViamVj
dDogW1BBVENIXSBGaXggcGdfd2FpdF9ldmVudHMgdXNhZ2UgZXhhbXBsZQoKVGhpcyBtYWtl
cyB0aGUgdXNlIG9mIGNvbHVtbiBhbGlhc2VzIGNvbnNpc3RlbnQgdGhyb3VnaG91dCB0aGUg
cXVlcnkuCi0tLQogZG9jL3NyYy9zZ21sL21vbml0b3Jpbmcuc2dtbCB8IDIgKy0KIDEgZmls
ZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBh
L2RvYy9zcmMvc2dtbC9tb25pdG9yaW5nLnNnbWwgYi9kb2Mvc3JjL3NnbWwvbW9uaXRvcmlu
Zy5zZ21sCmluZGV4IDExNDkwOTNhOGEuLjNmNDlmZjc5ZjMgMTAwNjQ0Ci0tLSBhL2RvYy9z
cmMvc2dtbC9tb25pdG9yaW5nLnNnbWwKKysrIGIvZG9jL3NyYy9zZ21sL21vbml0b3Jpbmcu
c2dtbApAQCAtMTExOSw3ICsxMTE5LDcgQEAgU0VMRUNUIGEucGlkLCBhLndhaXRfZXZlbnQs
IHcuZGVzY3JpcHRpb24KICAgRlJPTSBwZ19zdGF0X2FjdGl2aXR5IGEgSk9JTgogICAgICAg
IHBnX3dhaXRfZXZlbnRzIHcgT04gKGEud2FpdF9ldmVudF90eXBlID0gdy50eXBlIEFORAog
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGEud2FpdF9ldmVudCA9IHcubmFtZSkKLSAg
V0hFUkUgd2FpdF9ldmVudCBpcyBOT1QgTlVMTCBhbmQgYS5zdGF0ZSA9ICdhY3RpdmUnOwor
ICBXSEVSRSBhLndhaXRfZXZlbnQgaXMgTk9UIE5VTEwgYW5kIGEuc3RhdGUgPSAnYWN0aXZl
JzsKIC1bIFJFQ09SRCAxIF0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0mendzcDstLS0tLS0tLS0tLS0KIHBpZCAgICAgICAgIHwgNjg2
Njc0CiB3YWl0X2V2ZW50ICB8IFdBTEluaXRTeW5jCi0tIAoyLjM0LjEKCg==

--------------lZCrN8dAhCGCN9k0WXw0TB3t--