public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Paul Jungwirth <[email protected]>
To: Aleksander Alekseev <[email protected]>
To: PostgreSQL Hackers <[email protected]>
Subject: Re: format_datum debugging function
Date: Thu, 15 Aug 2024 09:50:15 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<CAJ7c6TO9CiAoGHYK=SMCTrXyoYAn4U=7c35QBgWwF9=H-3Bp=w@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>

On 14.08.24 17:46, Paul Jungwirth wrote:
> On 8/14/24 02:16, Peter Eisentraut wrote:
>> On 12.08.24 23:15, Paul Jungwirth wrote:
>>> On 8/12/24 04:32, Aleksander Alekseev wrote:
>>>>> [...] This function takes a Datum and the appropriate out function, 
>>>>> and returns a char *. So you
>>>>> can do this:
>>>>>
>>>>> (gdb) call format_datum(range_out, $1)
>>>>> $2 = 0x59162692d938 "[1,4)"
>>>>>
>>>>> I assume a patch like this doesn't need documentation. Does it need 
>>>>> a test? Anything else?
>>>>
>>>> I think you forgot to attach the patch. Or is it just a proposal?
>>>
>>> Sorry, patch attached here.
>>
>> I don't think it's safe to call output functions at arbitrary points 
>> from a debugger.  But if you're okay with that during development, 
>> say, then I think you could just call 
>> OidOutputFunctionCall(F_RANGE_OUT, $1)?
> 
> I assumed it wasn't safe everywhere (e.g. there is potentially a TOAST 
> lookup), but for debugging a patch that's okay with me.
> 
> Are you doing something to get macro expansion? I've never gotten my gdb 
> to see #defines, although in theory this configure line should do it, 
> right?:

Oh I see, you don't have the F_* constants available then.  Maybe just 
put in the OID manually then?

view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: format_datum debugging function
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox