Feedback-ID: i131946ab:Fastmail
Message-ID: <4fab82d1-a0f5-0d01-4d6c-0b780b5eea3a@enterprisedb.com>
Date: Thu, 17 Nov 2022 16:09:22 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.1
Subject: Re: libpq compression (part 2)
Content-Language: en-US
To: Andrey Borodin <amborodin86@gmail.com>,
 Justin Pryzby <pryzby@telsasoft.com>
Cc: Jacob Champion <jchampion@timescale.com>,
 Daniil Zakhlystov <usernamedt@yandex-team.ru>,
 pgsql-hackers@lists.postgresql.org, Andrey Borodin <x4mmm@yandex-team.ru>
References: <D29C2E5B-30FA-4870-9CC8-D49DACDED7AF@yandex-team.ru>
 <20220113235827.GM14051@telsasoft.com>
 <18CFC392-0391-4439-9F02-FC1CF02FFA24@yandex-team.ru>
 <20220118043919.GA23027@telsasoft.com> <20220302213352.GA27651@telsasoft.com>
 <D80C1D8A-ECF3-43DA-8F80-A74DD722F77D@yandex-team.ru>
 <dcb059f2-f226-2aa3-6f34-2ec95ca45813@timescale.com>
 <CAAhFRxifYwm+nvm_z082gFSTnaU1jFWbeTwxTs9ztD1aPVOfng@mail.gmail.com>
 <CAAhFRxj1fEM7XmS2nPnCYiq+1dFH4pvC09GkvX2Y8AM66ijOuA@mail.gmail.com>
 <CAAhFRxicA=0EBxhJfJJLkP62BKX0_UUWM4uaYj8Gwk54r48TiA@mail.gmail.com>
 <20221116031728.GI26337@telsasoft.com>
 <CAAhFRxj_MuHG3Hrn5SJah+dwGL22FZ1wSMCtZ=PNyfO1vMtb-w@mail.gmail.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: 
 <CAAhFRxj_MuHG3Hrn5SJah+dwGL22FZ1wSMCtZ=PNyfO1vMtb-w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/4fab82d1-a0f5-0d01-4d6c-0b780b5eea3a%40enterprisedb.com>
Precedence: bulk

On 17.11.22 01:27, Andrey Borodin wrote:
> Also I've found one more TODO item for the patch. Currently in
> fe-connect.c patch is doing buffer reset:
> conn->inStart = conn->inCursor = conn->inEnd = 0;
> This effectively consumes butes up tu current cursor. However, packet
> inspection is continued. The patch works because in most cases
> following code will issue re-read of message. Coincidentally.
> /* Get the type of request. */
> if (pqGetInt((int *) &areq, 4, conn))
> {
> /* We'll come back when there are more data */
> return PGRES_POLLING_READING;
> }

Note that the above code was just changed in dce92e59b1.  I don't know 
how that affects this patch set.