Subject: Re: pg_upgrade does not upgrade pg_stat_statements properly
To: Julien Rouhaud <rjuju123@gmail.com>,
 Dave Cramer <davecramer@postgres.rocks>
Cc: Bruce Momjian <bruce@momjian.us>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: 
 <CAOBaU_ZRhXZN9qfWfyO+8pSLX6McFVwLYoDcsMtpvhd0pdiz3g@mail.gmail.com>
 <c23c3355-e7a3-4fbe-2521-32d5944b48b3@wi3ck.info>
 <20210730020257.jpvunvworyqsaz43@nol>
 <CADK3HHJ4BmJqB+BLHa-UL464q0_dLxkTA6sB51JAp6DOMpfufw@mail.gmail.com>
 <20210730103945.nc2zl74v5czy2qwd@nol>
 <CADK3HHKz4ruqmqiph2cLvg53AibAPsEyen4uDXe1h5bu-nwWjg@mail.gmail.com>
 <20210730110728.tqt3oeohyvtuqqk7@nol>
 <CADK3HHJj3Zw7rHP=WzLKKg8_o-KmNH48gsxDaVPFB+gLzySBJg@mail.gmail.com>
 <20210730112832.wt3zdv32gllohope@nol>
 <CADK3HHKGk-YZ-FR2_nY+GeBKmYPuGbS33KUE2NM+F9oHQby_Hg@mail.gmail.com>
 <20210730114052.smbpww3l5yw6pypi@nol>
From: Jan Wieck <jan@wi3ck.info>
Message-ID: <4fbc3375-db33-694b-1635-0a6796da6023@wi3ck.info>
Date: Fri, 30 Jul 2021 12:44:17 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210730114052.smbpww3l5yw6pypi@nol>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/4fbc3375-db33-694b-1635-0a6796da6023%40wi3ck.info>
Precedence: bulk

On 7/30/21 7:40 AM, Julien Rouhaud wrote:
> On Fri, Jul 30, 2021 at 07:33:55AM -0400, Dave Cramer wrote:
>> 
>> Ah, ok, got it, thanks. Well I'm not sure how to deal with this.
>> The only thing I can think of is that we add a post_upgrade function to the
>> API.
>> 
>> All extensions would have to implement this.
> 
> It seems like a really big hammer for a niche usage.  As far as I know I'm the
> only one who wrote an extension that can create different objects depending on
> the server version, so I'm entirely fine with dealing with that problem in my
> extension rather than forcing everyone to implement an otherwise useless API.
> 
> Now if that API can be useful for other cases or if there are other extensions
> with similar problems that would be different story.
> 

I haven't worked on it for a while, but I think pl_profiler does the 
same thing, so you are not alone.


Jan

-- 
Jan Wieck