Message-ID: <4ff427ca-7986-4d13-820f-199672ab81ff@163.com>
Date: Mon, 20 Apr 2026 16:49:35 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: EXCEPT TABLE - Case inconsistency for describe \d and \dRp+
To: Peter Smith <smithpb2250@gmail.com>, vignesh C <vignesh21@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>,
 =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: 
 <CAHut+Pt3t_tCYwDStkj5fG4Z=YXrHvPBA7iGdh745QipC5zKeg@mail.gmail.com>
 <aeDs7iZUox1bbKAK@alvherre.pgsql>
 <CAHut+Psq7qmQSQCZA_HZcFv9ADCHDUPqCyFuTKfPDU-GUGihhQ@mail.gmail.com>
 <CAA4eK1LKQTHkVWdrS9vBfiaAf5kVuU-qOx_FD2u1F4zB9hz4PA@mail.gmail.com>
 <CAHut+Puic9YTrdj3B4BX1J-m=EJTtF5bhxk8cJpKJVrw6QWMLA@mail.gmail.com>
 <CALDaNm12mTxd10yHcf2SyDfkpbfWqHJb=m90cwfaEJnEBbPOXQ@mail.gmail.com>
 <CAHut+PuTH35hTKaP_+wuUepAbuWC2YLizG1aqxjvJP_fPBFFVQ@mail.gmail.com>
From: Yuchen Li <liyuchen_xyz@163.com>
In-Reply-To: 
 <CAHut+PuTH35hTKaP_+wuUepAbuWC2YLizG1aqxjvJP_fPBFFVQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/4ff427ca-7986-4d13-820f-199672ab81ff%40163.com>
Precedence: bulk

On 4/20/2026 2:46 PM, Peter Smith wrote:
>>> PSA  v3 patches.
>>>
>>> v3-0001 - Fixed the TABLE describe footer titles as suggested.
>>> - "Included in publications:"
>>> - "Excluded from publications:"
>>>
>>> v3-0002 - Made similar footer title changes for SEQUENCE describe
>>>
>>> v3-0003 - Made similar footer title changes for SHCEMA describe. In
>>> passing, I found that this \dn describe output was not even being
>>> tested, so I added the missing regression test.
>> I'm not sure separate patches are necessary for this change; it might
>> be better to merge them into a single patch. Other than that, the
>> changes look good.
>>
> I separated them because only the changes to TABLE \d had previously
> been discussed.
>
> If everyone thinks all changes are good, then I can combine them into one patch.
>
> ======
> Kind Regards,
> Peter Smith.
> Fujitsu Australia.
>
While reviewing 0003, I noticed a formatting issue in the following line:

+             * schema mapping count +  1 (for storing NULL).

There is an extra space after "count +".

Regards,
Yuchen Li