From: Tom Lane <tgl@sss.pgh.pa.us>
To: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@alvh.no-ip.org>
cc: Andrew Dunstan <andrew@dunslane.net>,
        Mahendra Singh Thalor <mahi6run@gmail.com>,
        Nathan Bossart <nathandbossart@gmail.com>,
        Srinath Reddy <srinath2133@gmail.com>,
        pgsql-hackers@lists.postgresql.org
Subject: Re: getting "shell command argument contains a newline or carriage return:" error with pg_dumpall when db name have new line in double quote
In-reply-to: <202602021048.m5lsx277xfuw@alvherre.pgsql>
References: <202602021048.m5lsx277xfuw@alvherre.pgsql>
Comments: In-reply-to =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@alvh.no-ip.org>
	message dated "Mon, 02 Feb 2026 11:54:34 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <500510.1770041668.1@sss.pgh.pa.us>
Date: Mon, 02 Feb 2026 09:14:28 -0500
Message-ID: <500511.1770041668@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/500511.1770041668%40sss.pgh.pa.us>
Precedence: bulk

=?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@alvh.no-ip.org> writes:
> This is not an objection to this patch, but I don't see why we should
> allow newlines in tablespace names if we're going to restrict them in
> names of roles and databases.  Is it only because pg_dumpall happens not
> to dump a comment with the tablespace name on it, like we do for dbs and
> roles?  Sounds unprincipled.
> I think keeping these things under the same rules makes the most sense.

Yeah, I was thinking the same.

			regards, tom lane