To: pgsql-hackers@lists.postgresql.org
From: Matthew Stickney <mtstickney@gmail.com>
Subject: [PATCH] (Windows) psql echoes password when reading from pipe
Message-ID: <502a1fff-862b-da52-1031-f68df6ed5a2d@gmail.com>
Date: Tue, 22 May 2018 00:27:48 -0400
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="------------4C7867A3B04357AFECA067FC"
Content-Language: en-US
Precedence: bulk

This is a multi-part message in MIME format.
--------------4C7867A3B04357AFECA067FC
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

This is my first time submitting a patch here; apologies in advance if I 
flub the process.

On windows, if you pipe data to psql, the password prompt correctly 
reads from and writes to the console, but the password text is echoed to 
the console. This is because echoing is disabled on the handle for 
stdin, but as part of a pipeline stdin doesn't refer to the console. 
I've attached a patch that gets a handle to the console's input buffer 
by opening CONIN$ instead, which corrects the problem.

I think the change is straightforward enough to apply directly, but 
there's another concern that might bear discussion: SetConsoleMode can 
fail, and when it does prompt input will be echoed (i.e. it's 
fail-open). Is it worth check for and reporting for an error there? 
Given that this is meant to be used interactively, I think the risk of 
someone not noticing the echo is low.

-Matt Stickney


--------------4C7867A3B04357AFECA067FC
Content-Type: text/plain; charset=UTF-8;
 name="0001-Disable-input-echo-on-the-console-not-stdin.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="0001-Disable-input-echo-on-the-console-not-stdin.patch"

RnJvbSAyN2EwZjliMjAzNjY4MDU2NGVmNmRmYTU0ZjM5NjFhZjIyMWNiYzUwIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXR0aGV3IFN0aWNrbmV5IDxtdHN0aWNrbmV5QGdt
YWlsLmNvbT4KRGF0ZTogTW9uLCAyMSBNYXkgMjAxOCAyMzoyNDozNCAtMDQwMApTdWJqZWN0
OiBbUEFUQ0hdIERpc2FibGUgaW5wdXQgZWNobyBvbiB0aGUgY29uc29sZSwgbm90IHN0ZGlu
LgoKV2hlbiBkYXRhIGlzIHBpcGVkIHRvIHBzcWwsIGEgaGFuZGxlIHRvIHN0ZGluIHdpbGwg
bm8gbG9uZ2VyIGJlIGEgaGFuZGxlCnRvIHRoZSBjb25zb2xlOyBTZXRDb25zb2xlTW9kZSB3
aWxsIGZhaWwsIGFuZCBwcm9tcHQgaW5wdXQgd2lsbCBiZSBlY2hvZWQKdG8gdGhlIHNjcmVl
bi4KCkluc3RlYWQsIHVzZSBDcmVhdGVGaWxlIHRvIGdldCBhIGhhbmRsZSB0byB0aGUgY29u
c29sZSdzIGlucHV0IGJ1ZmZlciBieQpvcGVuaW5nIENPTklOJCwgYW5kIHNldCB0aGUgY29u
c29sZSBtb2RlIHRoZXJlLiBQcm9tcHQgaW5wdXQgaXMgYWxyZWFkeQpiZWluZyByZWFkIGZy
b20gQ09OSU4kLCBzbyBub3cgcHJvbXB0LXJlbGF0ZWQgSS9PIG1vZGlmaWNhdGlvbnMgYWx0
ZXIgdGhlCnNhbWUgYnVmZmVyLgp0aGUgc2FtZSBidWZmZXIuCmNvbnNpc3RlbnRseS4KLS0t
CiBzcmMvcG9ydC9zcHJvbXB0LmMgfCAzICsrLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0
aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL3NyYy9wb3J0L3Nwcm9tcHQu
YyBiL3NyYy9wb3J0L3Nwcm9tcHQuYwppbmRleCA3MGRmYTY5ZDdiLi5mNTdiNDliZDNhIDEw
MDY0NAotLS0gYS9zcmMvcG9ydC9zcHJvbXB0LmMKKysrIGIvc3JjL3BvcnQvc3Byb21wdC5j
CkBAIC0xMTIsNyArMTEyLDcgQEAgc2ltcGxlX3Byb21wdChjb25zdCBjaGFyICpwcm9tcHQs
IGNoYXIgKmRlc3RpbmF0aW9uLCBzaXplX3QgZGVzdGxlbiwgYm9vbCBlY2hvKQogCWlmICgh
ZWNobykKIAl7CiAJCS8qIGdldCBhIG5ldyBoYW5kbGUgdG8gdHVybiBlY2hvIG9mZiAqLwot
CQl0ID0gR2V0U3RkSGFuZGxlKFNURF9JTlBVVF9IQU5ETEUpOworCQl0ID0gQ3JlYXRlRmls
ZSgiQ09OSU4kIiwgR0VORVJJQ19SRUFEIHwgR0VORVJJQ19XUklURSwgRklMRV9TSEFSRV9S
RUFEIHwgRklMRV9TSEFSRV9XUklURSwgTlVMTCwgT1BFTl9FWElTVElORywgMCwgTlVMTCk7
CiAKIAkJLyogc2F2ZSB0aGUgb2xkIGNvbmZpZ3VyYXRpb24gZmlyc3QgKi8KIAkJR2V0Q29u
c29sZU1vZGUodCwgJnRfb3JpZyk7CkBAIC0xNjQsNiArMTY0LDcgQEAgc2ltcGxlX3Byb21w
dChjb25zdCBjaGFyICpwcm9tcHQsIGNoYXIgKmRlc3RpbmF0aW9uLCBzaXplX3QgZGVzdGxl
biwgYm9vbCBlY2hvKQogCXsKIAkJLyogcmVzZXQgdG8gdGhlIG9yaWdpbmFsIGNvbnNvbGUg
bW9kZSAqLwogCQlTZXRDb25zb2xlTW9kZSh0LCB0X29yaWcpOworCQlDbG9zZUhhbmRsZSh0
KTsKIAkJZnB1dHMoIlxuIiwgdGVybW91dCk7CiAJCWZmbHVzaCh0ZXJtb3V0KTsKIAl9Ci0t
IAoyLjE2LjIud2luZG93cy4xCgo=
--------------4C7867A3B04357AFECA067FC--