From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Undesirable entries in typedefs list
In-reply-to: 
 <CAA8=A79aEmShju8h8o4ijmYhRaZouznkG3DWUfMNCQQ_Ec65_w@mail.gmail.com>
References: <28690.1521912334@sss.pgh.pa.us>
 <CAA8=A79p+5TXLrOy0UY35fEuGG=_pV7yKJuOZyR=hxnjFKqG0A@mail.gmail.com>
 <CAA8=A79aEmShju8h8o4ijmYhRaZouznkG3DWUfMNCQQ_Ec65_w@mail.gmail.com>
Comments: In-reply-to Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
	message dated "Mon, 26 Mar 2018 11:13:21 +1030"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <502.1522188167.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 27 Mar 2018 18:02:47 -0400
Message-ID: <503.1522188167@sss.pgh.pa.us>
Precedence: bulk

Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
>> pgindent already has a list of blacklisted typedefs (see lines 121 to 1=
23)

Oh, so it does.

> Here's a patch to pgindent which I think will do what you want fairly
> simply, assuming you have identified all the offending tokens.

Hm, this does not work for me (with perl 5.10.1), I get syntax errors like

Not enough arguments for map at src/tools/pgindent/pgindent line 64, near =
"abs allocfunc iterator other pointer printfunc reference string type )"
  (Might be a runaway multi-line () string starting on line 63)
syntax error at src/tools/pgindent/pgindent line 64, near "abs allocfunc i=
terator other pointer printfunc reference string type )"
Execution of src/tools/pgindent/pgindent aborted due to compilation errors=
.

After reading the perlfunc man page I changed

-my %blacklist =3D map { "$_\n" =3D> 1 }
+my %blacklist =3D map { +"$_\n" =3D> 1 }

and then it seems to work, but man this is an ugly language :-(

			regards, tom lane