Subject: Re: [Proposal] Global temporary tables
To: =?UTF-8?B?5pu+5paH5peM?= <wenjing.zwj@alibaba-inc.com>,
 Prabhat Sahu <prabhat.sahu@enterprisedb.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>,
 Robert Haas <robertmhaas@gmail.com>,
 Tomas Vondra <tomas.vondra@2ndquadrant.com>,
 Konstantin Knizhnik <k.knizhnik@postgrespro.ru>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>, =?UTF-8?B?6JSh5p2+6Zyy?=
 =?UTF-8?B?KOWtkOWYiSk=?= <zijia@taobao.com>, "Cai, Le"
 <le.cai@alibaba-inc.com>, =?UTF-8?B?6JCn5bCR6IGqKOmTgeW6tSk=?=
 <shaocong.xsc@alibaba-inc.com>
References: <24099f4e-742c-e92b-729c-77bac1ca80d4@postgrespro.ru>
 <AE2D2EE3-B9E6-4ACA-AC91-304347F224CE@alibaba-inc.com>
 <CANEvxPrEAtmWN6z8T3ed81V5WZBxfrQ2LmHO1uOEOeUBh83Z-Q@mail.gmail.com>
 <77320A29-DC39-4EFE-A5E2-0A00F6A316E8@alibaba-inc.com>
 <e236c065-f2ad-bc88-ce44-b101cbf44727@enterprisedb.com>
 <E75612C2-00C9-4997-9D37-762A3D0E8482@alibaba-inc.com>
 <7eb93026-0f35-325a-132f-ca183a5da3ac@enterprisedb.com>
 <7CCE7DE5-5E85-4155-9010-5EDEAE762194@alibaba-inc.com>
 <087bd809-e1d7-ee44-da1f-25996abad442@enterprisedb.com>
 <40391A22-CB8B-4143-B936-7707667F7905@alibaba-inc.com>
 <CANEvxPpfTrNGXw2K3MzFMt6NGBAQwLXbv6SHJ_XBEfqEimJxJA@mail.gmail.com>
 <68FC0EB3-8E39-4300-B9ED-036F4163C791@alibaba-inc.com>
 <CANEvxPrVan7f_JgVr5chaOHGtMHFfL-A5hVcYbQj_-5aYWvDRQ@mail.gmail.com>
 <A5C70102-DFFB-40AF-9591-E3875C745513@alibaba-inc.com>
 <CANEvxPpAxb30mnWdp4YZvwFF28A3zf3LCuEg91BE1djRTYSZcg@mail.gmail.com>
 <25D7E36F-B2D6-4A63-BFC7-E1FD24EA6BE0@alibaba-inc.com>
From: tushar <tushar.ahuja@enterprisedb.com>
Message-ID: <507b246f-4350-f4af-3950-a334be7c2cf2@enterprisedb.com>
Date: Fri, 27 Mar 2020 14:51:21 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <25D7E36F-B2D6-4A63-BFC7-E1FD24EA6BE0@alibaba-inc.com>
Content-Type: multipart/alternative;
 boundary="------------ADD0934EA7C39F6FDFAD127A"
Content-Language: en-US
Precedence: bulk

This is a multi-part message in MIME format.
--------------ADD0934EA7C39F6FDFAD127A
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit

On 3/27/20 10:55 AM, 曾文旌 wrote:
>> Hi Wenjing,
>> This patch(gtt_v21_pg13.patch) is not applicable on PG HEAD, I hope 
>> you have prepared the patch on top of some previous commit.
>> Could you please rebase the patch which we can apply on HEAD ?
> Yes, It looks like the built-in functions are in conflict with new code.
>
>
This error message looks wrong  to me-

postgres=# reindex table concurrently t ;
ERROR:  cannot create indexes on global temporary tables using 
concurrent mode
postgres=#

Better message would be-

ERROR:  cannot reindex global temporary tables concurrently

-- 
regards,tushar
EnterpriseDB  https://www.enterprisedb.com/
The Enterprise PostgreSQL Company


--------------ADD0934EA7C39F6FDFAD127A
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: 8bit

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <div class="moz-cite-prefix">On 3/27/20 10:55 AM, 曾文旌 wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:25D7E36F-B2D6-4A63-BFC7-E1FD24EA6BE0@alibaba-inc.com">
      <blockquote type="cite" class="">
        <div class="">
          <div dir="ltr" class="">
            <div class="gmail_quote">
              <div class=""><span class="gmail_default"
                  style="font-family:verdana,sans-serif">Hi Wenjing,</span></div>
              <div class=""><span class="gmail_default"
                  style="font-family:verdana,sans-serif">This
                  patch(gtt_v21_pg13.patch) is not applicable on PG
                  HEAD, I hope you have prepared the patch on top of
                  some previous commit.</span> <br class="">
              </div>
              <div class="">
                <div style="font-family:verdana,sans-serif"
                  class="gmail_default">Could you please rebase the
                  patch which we can apply on HEAD ?<br class="">
                </div>
              </div>
            </div>
          </div>
        </div>
      </blockquote>
      <div>Yes, It looks like the built-in functions are in conflict
        with new code.</div>
      <div><br class="">
      </div>
      <div><br class="">
      </div>
    </blockquote>
    <p>This error message looks wrong  to me-</p>
    <p>postgres=# reindex table concurrently t ;<br>
      ERROR:  cannot create indexes on global temporary tables using
      concurrent mode<br>
      postgres=# </p>
    <p>Better message would be-</p>
    <p>ERROR:  cannot reindex global temporary tables concurrently<br>
      <br>
    </p>
    <pre class="moz-signature" cols="72">-- 
regards,tushar
EnterpriseDB  <a class="moz-txt-link-freetext" href="https://www.enterprisedb.com/">https://www.enterprisedb.com/</a>
The Enterprise PostgreSQL Company
</pre>
  </body>
</html>

--------------ADD0934EA7C39F6FDFAD127A--