Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tIDXA-00Cyby-IL for pgsql-hackers@arkaria.postgresql.org; Mon, 02 Dec 2024 21:00:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tIDX7-003UPw-R6 for pgsql-hackers@arkaria.postgresql.org; Mon, 02 Dec 2024 21:00:43 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tIDX7-003UPk-Gx for pgsql-hackers@lists.postgresql.org; Mon, 02 Dec 2024 21:00:42 +0000 Received: from mail.postgrespro.ru ([93.174.131.139]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tIDX6-000iI2-1L for pgsql-hackers@postgresql.org; Mon, 02 Dec 2024 21:00:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mx2023; t=1733173240; bh=cNJUj864bFi7vkoJlOlaG9QZocXeeB5N8hGQxPdlZ8M=; h=Message-ID:Date:User-Agent:Subject:To:Cc:References:From: In-Reply-To:From; b=geWOnKFnQHLCO4+QhAiYveksCrM8xLySV9rzSIQPnpvsMYEkZw3Ac/siqkYQc96RC DXjadkQToQnUu2RwEAui22Nx4k4Zfn80pMpBy7HhtnRV07zm5XB4qUfn/SQgr04JcX beSy+UghgRTUtwpftiGYb3x21htC2eyl/RAp0YnOdVcXWSwIoRcyXwDol6CIa1u458 Th9dyZ5Chu84Bf2rQD9RfUppVhsQNKrVr95MQfn/QyXhJX4rVR5Q9ViLvqudC0snyX LuQ4eZON3bixhjHuSzu28fOKb8yOZ1x32U2TXLYJwXwfivX6h7fjYLT+VWYhdTS9Ui Yt7x3HyCn2++w== Received: from [172.20.10.4] (unknown [89.113.152.1]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: a.rybakina@postgrespro.ru) by mail.postgrespro.ru (Postfix/587) with ESMTPSA id 204D25FF34; Tue, 3 Dec 2024 00:00:38 +0300 (MSK) Message-ID: <508c2441-db54-46c4-b521-e4a0f5ca7ca1@postgrespro.ru> Date: Tue, 3 Dec 2024 00:00:37 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Vacuum statistics To: Ilia Evdokimov Cc: Jim Nasby , Andrei Zubkov , Masahiko Sawada , Melanie Plageman , jian he , pgsql-hackers , a.lepikhov@postgrespro.ru, Alexander Korotkov References: <9b10c6d3-52c4-4eef-b67c-c33442667729@postgrespro.ru> <9485d892-fd04-4e3a-ac24-7dd767cb7333@postgrespro.ru> <0B6CBF4C-CC2A-4200-9126-CE3A390D938B@upgrade.com> <6732acf8ce0f31025b535ae1a64568750924a887.camel@moonset.ru> <5AA8FFD5-6DE2-4A31-8E00-AE98F738F5D1@upgrade.com> <85b963fe-5977-43aa-9241-75b862abcc69@postgrespro.ru> <9C7A167C-DCDE-4A17-9ABE-6276723FEC50@upgrade.com> <2d493cf9-9ba7-4cc1-a3f2-67afd7c163ee@postgrespro.ru> Content-Language: en-US From: Alena Rybakina In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-KSMG-AntiPhishing: NotDetected X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.1.0.7854, bases: 2024/12/02 19:17:00 #26929507 X-KSMG-AntiVirus-Status: NotDetected, skipped X-KSMG-LinksScanning: not scanned, disabled by settings X-KSMG-Message-Action: skipped X-KSMG-Rule-ID: 1 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 02.12.2024 17:46, Ilia Evdokimov wrote: > In my opinion, the patches are semantically correct. However, not all > dead code has been removed - I'm referring to > pgstat_update_snapshot(). Also, the tests need to be fixed. > Thank you, I'll fix it -- Regards, Alena Rybakina Postgres Professional