Feedback-ID: i131946ab:Fastmail
Message-ID: <50915523-5e3d-e1c7-9c38-d17263146e41@enterprisedb.com>
Date: Fri, 27 May 2022 14:45:57 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.9.0
Subject: Re: pg_upgrade test writes to source directory
Content-Language: en-US
To: Justin Pryzby <pryzby@telsasoft.com>,
 Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@postgresql.org
References: <f80ace33-11fb-1cd3-20f8-98f51d151088@enterprisedb.com>
 <Yo3Z5JzHXn7sIe9N@paquier.xyz>
 <b68a2c98-8690-c057-c9e1-79bc6db608a0@enterprisedb.com>
 <Yo/mWGJjCHOH3eB1@paquier.xyz> <20220526205218.GC19626@telsasoft.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <20220526205218.GC19626@telsasoft.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/50915523-5e3d-e1c7-9c38-d17263146e41%40enterprisedb.com>
Precedence: bulk

On 26.05.22 22:52, Justin Pryzby wrote:
> On Fri, May 27, 2022 at 05:43:04AM +0900, Michael Paquier wrote:
>> On Thu, May 26, 2022 at 04:36:47PM +0200, Peter Eisentraut wrote:
>>> I chose TESTOUTDIR because it corresponds to the tmp_check directory, so
>>> that the output files of the pg_upgrade run are removed when the test
>>> artifacts are cleaned up.  When using TESTDIR, the pg_upgrade output files
>>> end up in the build directory, which is less bad than the source directory,
>>> but still not ideal.
>>
>> Where does the choice of TESTOUTDIR come from?  I am a bit surprised
>> by this choice, to be honest, because there is no trace of it in the
>> buildfarm client or the core code.  TESTDIR, on the other hand, points
>> to tmp_check/ if not set.  It gets set it in vcregress.pl and
>> Makefile.global.in.
> 
> It looks like Peter working on top of the meson branch.
> TESTOUTDIR is not yet in master.

Ooops, yeah. :)

I think you can just chdir to ${PostgreSQL::Test::Utils::tmp_check}.