From: Tom Lane <tgl@sss.pgh.pa.us>
To: Chao Li <li.evan.chao@gmail.com>
cc: Nathan Bossart <nathandbossart@gmail.com>,
        Rahila Syed <rahilasyed90@gmail.com>,
        Robert Haas <robertmhaas@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgindent versus struct members and typedefs
In-reply-to: <347EA055-D626-414C-B10D-7E70041B9B55@gmail.com>
References: <aS9hkwnkWf3dZIA_@nathan>
 <347EA055-D626-414C-B10D-7E70041B9B55@gmail.com>
Comments: In-reply-to Chao Li <li.evan.chao@gmail.com>
	message dated "Wed, 03 Dec 2025 06:46:33 +0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <509792.1764715875.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 02 Dec 2025 17:51:15 -0500
Message-ID: <509793.1764715875@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/509793.1764715875%40sss.pgh.pa.us>
Precedence: bulk

Chao Li <li.evan.chao@gmail.com> writes:
> On Dec 3, 2025, at 06:00, Nathan Bossart <nathandbossart@gmail.com> wrot=
e:
>> I tried to fix pgindent for a few, but the code is basically impenetrab=
le.
>> I didn't find any fixes upstream [0], either.  As noted above, we could
>> also fix it by avoiding the naming conflicts.  However, I can't imagine
>> that's worth the churn, and I've already spent way too much time on thi=
s,
>> so IMHO the best thing to do here is nothing.

> I think that=E2=80=99s fine.

Agreed, not worth the trouble to fool with.

> Actually I see the other problem with pgindent, where if a =E2=80=9Celse=
=E2=80=9D clause contains a multiple-line comment and a single statement w=
ithout braces, for example:
> ...
> I tried to fix but failed. For that problem, a solution is to add braces=
 to the =E2=80=9Celse=E2=80=9D clause.

In this case, I think pgindent is indirectly enforcing good style.
I do not like omitting braces around anything that's more than one
line; readers have to pay close attention to whether the code is
doing what it was intended to.

			regards, tom lane