Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1TkWSH-0005aG-QW for pgsql-hackers@arkaria.postgresql.org; Mon, 17 Dec 2012 08:53:45 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.72) (envelope-from ) id 1TkWSG-0001P9-Nx for pgsql-hackers@arkaria.postgresql.org; Mon, 17 Dec 2012 08:53:44 +0000 Received: from makus.postgresql.org ([98.129.198.125]) by malur.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1TkWSF-0001Ow-K6 for pgsql-hackers@postgresql.org; Mon, 17 Dec 2012 08:53:43 +0000 Received: from smtp-outbound-1.vmware.com ([208.91.2.12]) by makus.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1TkWSC-0002r0-1g for pgsql-hackers@postgresql.org; Mon, 17 Dec 2012 08:53:41 +0000 Received: from sc9-mailhost1.vmware.com (sc9-mailhost1.vmware.com [10.113.161.71]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 30A78280CD; Mon, 17 Dec 2012 00:53:09 -0800 (PST) Received: from zcs-prod-ext-mta-1.vmware.com (zcs-prod-ext-mta-1.vmware.com [10.113.62.223]) by sc9-mailhost1.vmware.com (Postfix) with ESMTP id 1B8AA18510; Mon, 17 Dec 2012 00:53:09 -0800 (PST) Received: from localhost (localhost.localdomain [127.0.0.1]) by zcs-prod-ext-mta-1.vmware.com (Postfix) with ESMTP id BFDC41219B4; Mon, 17 Dec 2012 00:54:29 -0800 (PST) X-Virus-Scanned: amavisd-new at zcs-prod-ext-mta-1.vmware.com Received: from zcs-prod-ext-mta-1.vmware.com ([127.0.0.1]) by localhost (zcs-prod-ext-mta-1.vmware.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BDD3knfP53QC; Mon, 17 Dec 2012 00:54:29 -0800 (PST) Received: from localhost (localhost.localdomain [127.0.0.1]) by zcs-prod-ext-mta-1.vmware.com (Postfix) with ESMTP id 492691219CF; Mon, 17 Dec 2012 00:44:29 -0800 (PST) X-Virus-Scanned: amavisd-new at zcs-prod-ext-mta-1.vmware.com Received: from zcs-prod-ext-mta-1.vmware.com ([127.0.0.1]) by localhost (zcs-prod-ext-mta-1.vmware.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Ijj1RfUPtsws; Mon, 17 Dec 2012 00:44:29 -0800 (PST) Received: from [192.168.1.90] (unknown [10.113.62.14]) by zcs-prod-ext-mta-1.vmware.com (Postfix) with ESMTPSA id C40581219C8; Mon, 17 Dec 2012 00:31:38 -0800 (PST) Message-ID: <50CED81A.3080400@vmware.com> Date: Mon, 17 Dec 2012 10:30:18 +0200 From: Heikki Linnakangas Organization: VMware User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.10) Gecko/20121027 Icedove/10.0.10 MIME-Version: 1.0 To: Andres Freund CC: pgsql-hackers@postgresql.org Subject: Re: XLByte* usage References: <20121216141624.GC4683@awork2.anarazel.de> In-Reply-To: <20121216141624.GC4683@awork2.anarazel.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Pg-Spam-Score: -6.9 (------) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On 16.12.2012 16:16, Andres Freund wrote: > Now that XLRecPtr's are plain 64bit integers what are we supposed to use > in code comparing and manipulating them? There already is plenty example > of both, but I would like new code to go into one direction not two... > > I personally find direct comparisons/manipulations far easier to read > than the XLByte* equivalents. I've still used XLByte* macros, but I agree that plain < = > are easier to read. +1 for using < = > in new code. - Heikki -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers