Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1Tw1k9-0003o4-DD for pgsql-hackers@arkaria.postgresql.org; Fri, 18 Jan 2013 02:31:45 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.72) (envelope-from ) id 1Tw1k8-0004ar-UI for pgsql-hackers@arkaria.postgresql.org; Fri, 18 Jan 2013 02:31:44 +0000 Received: from makus.postgresql.org ([98.129.198.125]) by malur.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1Tw1k7-0004am-QA for pgsql-hackers@postgresql.org; Fri, 18 Jan 2013 02:31:43 +0000 Received: from outmail149113.authsmtp.com ([62.13.149.113]) by makus.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1Tw1k6-0003R5-4E for pgsql-hackers@postgresql.org; Fri, 18 Jan 2013 02:31:43 +0000 Received: from mail-c226.authsmtp.com (mail-c226.authsmtp.com [62.13.128.226]) by punt5.authsmtp.com (8.14.2/8.14.2/Kp) with ESMTP id r0I2Vcva077538; Fri, 18 Jan 2013 02:31:38 GMT Received: from ayaki.localdomain (58-7-88-192.dyn.iinet.net.au [58.7.88.192]) (authenticated bits=0) by mail.authsmtp.com (8.14.2/8.14.2/) with ESMTP id r0I2VTvI062197 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Fri, 18 Jan 2013 02:31:32 GMT Message-ID: <50F8B400.1090701@2ndQuadrant.com> Date: Fri, 18 Jan 2013 10:31:28 +0800 From: Craig Ringer Organization: 2nd Quadrant User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Andres Freund CC: Dimitri Fontaine , Tom Lane , Simon Riggs , Robert Haas , Alvaro Herrera , PostgreSQL Hackers Subject: Re: Event Triggers: adding information References: <16675.1358454278@sss.pgh.pa.us> <18941.1358462151@sss.pgh.pa.us> <20130118013334.GE3074@awork2.anarazel.de> In-Reply-To: <20130118013334.GE3074@awork2.anarazel.de> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Server-Quench: 2e0e2538-6117-11e2-98a9-0025907ec6c5 X-AuthReport-Spam: If SPAM / abuse - report it at: http://www.authsmtp.com/abuse X-AuthRoute: OCdxZQATClZeVg0b BQteCiN5VAwpPBRK HVkIKg5MJUcNSQVJ NksacRtFaQ1bZ1hf HGQLWldEUF97WmJ/ aA8faA1DZVRGVxtr WUpWQFdQERppT14B fxx4Nl8LdwNEeXd3 K0dkXHFdEkYvdRN/ R01cCGsHZGB9aWFK Ul1Rf1JdbQNKfBpM alcqB3VeZCtlM3Bw LC8aFBMcBw5qYAlL TwcRZW4IQEkEEyQn FVgLETkuG0JNRiM9 KAYjI0IdG0B5 X-Authentic-SMTP: 61633235383639.1020:706 X-AuthFastPath: 0 (Was 255) X-AuthSMTP-Origin: 58.7.88.192/2525 X-AuthVirus-Status: No virus detected - but ensure you scan with your own anti-virus system. X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On 01/18/2013 09:33 AM, Andres Freund wrote: > I have no problem requiring C code to use the even data, be it via > hooks or via C functions called from event triggers. The problem I > have with putting in some hooks is that I doubt that you can find > sensible spots with enough information to actually recreate the DDL > for a remote system without doing most of the work for command triggers. Is that so much of a problem if it's OK to break it between major versions? Maybe require compilation with -DPG_NON_FORWARD_COMPATIBLE to make the hooks visible in the headers, so nobody can claim they didn't know? -- Craig Ringer http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers