Message-ID: <50f693ad-faec-4b1b-8de5-88dc90b236b4@uni-muenster.de>
Date: Thu, 12 Feb 2026 16:33:59 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: COMMENTS are not being copied in CREATE TABLE LIKE
To: Fujii Masao <masao.fujii@gmail.com>,
 Matheus Alcantara <matheusssilv97@gmail.com>
Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
References: <e08cb97f-0364-4002-9cda-3c16b42e4136@uni-muenster.de>
 <DGD24UA7LASG.11H30IV2AFVA2@gmail.com>
 <CAHGQGwF-uuKkon8Ah9dbMiGKoYmFJyHZnDa_HcWWCXKnh7LJ2Q@mail.gmail.com>
Content-Language: de-DE, en-GB
From: Jim Jones <jim.jones@uni-muenster.de>
In-Reply-To: <CAHGQGwF-uuKkon8Ah9dbMiGKoYmFJyHZnDa_HcWWCXKnh7LJ2Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/50f693ad-faec-4b1b-8de5-88dc90b236b4%40uni-muenster.de>
Precedence: bulk


On 12/02/2026 16:08, Fujii Masao wrote:
> On Thu, Feb 12, 2026 at 11:36 PM Matheus Alcantara
> <matheusssilv97@gmail.com> wrote:
>> The patch fix the issue and it seems correct to me.

Thanks for the review!

> The documentation [1] states that INCLUDING COMMENTS copies comments for
> the copied columns, constraints, and indexes. It does not mention copying
> comments on the table itself. Therefore, not copying table comments with
> INCLUDING COMMENTS does not appear to be a bug. That is, the proposed patch
> seems more like an improvement than a bug fix.

Hmm, it seemed so obvious to me that I didn’t look more closely at the
documentation :) Although I struggle to see the rationale for not
copying a table’s comment in a CREATE TABLE LIKE ... INCLUDING COMMENTS
statement, I have to agree that the documentation is quite clear about
this limitation, and therefore it cannot really be considered a bug.
That said, it may well be worth considering for a future release.

What are your thoughts?

Thanks!

Best, Jim