From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Header checking failures on LLVM-less machines
In-reply-to: <20190129005553.tuydbrscrl454yqn@alap3.anarazel.de>
References: <19808.1548692361@sss.pgh.pa.us> <31363.1548723082@sss.pgh.pa.us>
 <20190129005553.tuydbrscrl454yqn@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Mon, 28 Jan 2019 16:55:53 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <509.1548724909.1@sss.pgh.pa.us>
Date: Mon, 28 Jan 2019 20:21:49 -0500
Message-ID: <510.1548724909@sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2019-01-28 19:51:22 -0500, Tom Lane wrote:
>> I propose that we should fix this by making the whole bodies of those
>> two headers be #ifdef USE_LLVM.

> Hm, I think it's sufficient that we error out if llvm was configured,
> we've sufficient buildfarm machines running with it enabled.

That is not the point.  The point is that you've broken a developer
tool.  I don't really care whether cpluspluscheck would work on
some subset of buildfarm machines --- what I need is for it to work
on *my* machine.  It is not any more okay for the llvm headers to fail
like this than it would be for libxml- or openssl- or Windows-dependent
headers to fail on machines lacking respective infrastructure.

(And yes, I realize that that means that cpluspluscheck can only
check a subset of the header declarations on any particular machine.
But there's no way around that.)

			regards, tom lane