From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
cc: Andrew Gierth <andrew@tao11.riddles.org.uk>, pgsql-hackers@postgresql.org
Subject: Re: Synchronize with imath upstream
In-reply-to: <20190203062048.GB6226@rfd.leadboat.com>
References: <20190203035704.GA6226@rfd.leadboat.com>
 <87y36x76r7.fsf@news-spur.riddles.org.uk>
 <20190203062048.GB6226@rfd.leadboat.com>
Comments: In-reply-to Noah Misch <noah@leadboat.com>
	message dated "Sat, 02 Feb 2019 22:20:48 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <5101.1549207886.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sun, 03 Feb 2019 10:31:26 -0500
Message-ID: <5102.1549207886@sss.pgh.pa.us>
Precedence: bulk

Noah Misch <noah@leadboat.com> writes:
> The -Wno-declaration-after-statement approach takes eight lines of code,=
 and
> the filter-out approach takes one.  On the other hand, using $(filter-ou=
t)
> changes any runs of whitespace to single spaces ("$(filter-out foo,a    =
b c)"
> yields "a b c").  We do risk that with CPPFLAGS and LDFLAGS in a few pla=
ces.
> I don't want to proliferate that practice, because it changes semantics =
of
> CFLAGS containing -DFOO=3D"arbitrary    text".

I don't particularly buy that argument, because CPPFLAGS is where any -D
switches ought to be put.  So we've already exposed ourselves to this
risk, in the unlikely scenario where it's not hypothetical.

			regards, tom lane