Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ndKbG-0002SH-Qq
	for pgsql-hackers@arkaria.postgresql.org; Sat, 09 Apr 2022 23:34:38 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ndKbF-0001lJ-N5
	for pgsql-hackers@arkaria.postgresql.org; Sat, 09 Apr 2022 23:34:37 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1ndKbF-0001lA-De
	for pgsql-hackers@lists.postgresql.org; Sat, 09 Apr 2022 23:34:37 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1ndKb8-0001L0-Sn
	for pgsql-hackers@postgresql.org; Sat, 09 Apr 2022 23:34:36 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 239NYQc0005112;
	Sat, 9 Apr 2022 19:34:26 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: pgsql-hackers@postgresql.org, Thomas Munro <thomas.munro@gmail.com>
Subject: Re: failures in t/031_recovery_conflict.pl on CI
In-reply-to: <20220409233107.v7okovwr46xsizfk@alap3.anarazel.de>
References: <20220409045515.35ypjzddp25v72ou@alap3.anarazel.de>
 <20220409050501.frejv2i46m54keem@alap3.anarazel.de>
 <20220409220054.fqn5arvbeesmxdg5@alap3.anarazel.de>
 <20220409231002.mddrr7mtca7p55v5@alap3.anarazel.de>
 <20220409233107.v7okovwr46xsizfk@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Sat, 09 Apr 2022 16:31:07 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <5110.1649547266.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sat, 09 Apr 2022 19:34:26 -0400
Message-ID: <5111.1649547266@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/5111.1649547266%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> It's been broken in different ways all the way back to 9.0, from what I =
can
> see, but I didn't check every single version.

> Afaics the fix is to nuke the idea of doing anything substantial in the =
signal
> handler from orbit, and instead just set a flag in the handler.

+1.  This is probably more feasible given the latch infrastructure
than it was when that code was first written.

			regards, tom lane