Message-ID: <51113492.6090108@dunslane.net>
Date: Tue, 05 Feb 2013 11:34:26 -0500
From: Andrew Dunstan <andrew@dunslane.net>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:15.0) Gecko/20120827 Thunderbird/15.0
MIME-Version: 1.0
To: Craig Ringer <craig@2ndquadrant.com>
CC: Noah Misch <noah@leadboat.com>, Brar Piening <brar@gmx.de>,
	Heikki Linnakangas <hlinnakangas@vmware.com>,
	Magnus Hagander <magnus@hagander.net>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Visual Studio 2012 RC
References: <20130101025421.GA17763@tornado.leadboat.com>
	<50FD0B35.3020503@2ndQuadrant.com> <50FD3840.8010700@dunslane.net>
	<50FD3D5B.9040506@2ndQuadrant.com>
	<50FF7FD0.7050705@2ndQuadrant.com>
	<50FF897B.2050603@2ndQuadrant.com>
	<20130124013825.GA29954@tornado.leadboat.com>
	<5100AA63.2050604@2ndQuadrant.com> <5100C2FD.70800@2ndQuadrant.com>
	<510359A8.3020100@2ndQuadrant.com>
	<20130126145608.GA19977@tornado.leadboat.com>
	<510BA318.2030503@2ndquadrant.com> <510BC942.2040307@dunslane.net>
In-Reply-To: <510BC942.2040307@dunslane.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


On 02/01/2013 08:55 AM, Andrew Dunstan wrote:
>
> On 02/01/2013 06:12 AM, Craig Ringer wrote:
>> On 01/26/2013 10:56 PM, Noah Misch wrote:
>>> On Sat, Jan 26, 2013 at 12:20:56PM +0800, Craig Ringer wrote:
>>>> Just to confirm, I think that this is ready for commit as posted in
>>>> 20130101025421.GA17763@tornado.leadboat.com.
>>>>
>>>> I'll amend my docs changes and submit them separately.
>>> Thanks.  Here's a rebased version.
>> Is there any chance someone could pick this up for 9.3 before it 
>> diverges too much? It's ready to go, Windows only, and tested.
>>
>> https://commitfest.postgresql.org/action/patch_view?id=1023
>>
>>
>
>
>
> I expect to get to it in due course if nobody else does. I have been 
> set back some by the death and replacement of my Windows workstation, 
> (plus coming to terms with Windows 8).
>
>


OK, I have looked at this and it seems perfectly sane. In fact, after a 
very frustrating time VS2012 is the *only* way I have found to get a 64 
bit build using MS tools on Windows 8. Given that, I propose to backport 
these changes to 9.2 so we can get some buildfarm coverage of that tool 
chain that includes the latest stable release.

cheers

andrew


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers