From: Tom Lane <tgl@sss.pgh.pa.us>
To: Chao Li <li.evan.chao@gmail.com>
cc: Nathan Bossart <nathandbossart@gmail.com>,
        Rahila Syed <rahilasyed90@gmail.com>,
        Robert Haas <robertmhaas@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgindent versus struct members and typedefs
In-reply-to: <5E70CB69-1E2D-471B-8CF8-83205E5E14CE@gmail.com>
References: <aS9hkwnkWf3dZIA_@nathan>
 <347EA055-D626-414C-B10D-7E70041B9B55@gmail.com>
 <509793.1764715875@sss.pgh.pa.us>
 <5E70CB69-1E2D-471B-8CF8-83205E5E14CE@gmail.com>
Comments: In-reply-to Chao Li <li.evan.chao@gmail.com>
	message dated "Wed, 03 Dec 2025 07:06:45 +0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <512379.1764717196.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 02 Dec 2025 18:13:16 -0500
Message-ID: <512380.1764717196@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/512380.1764717196%40sss.pgh.pa.us>
Precedence: bulk

Chao Li <li.evan.chao@gmail.com> writes:
>> On Dec 3, 2025, at 06:51, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> In this case, I think pgindent is indirectly enforcing good style.
>> I do not like omitting braces around anything that's more than one
>> line; readers have to pay close attention to whether the code is
>> doing what it was intended to.

> For =E2=80=9Cone line=E2=80=9D, do you mean only a single line of statem=
ent or one line statement plus one line comment?

In my head, a comment and a statement are two lines, and so need
wrapping braces as much as two statements would do.  I realize that
C compilers think differently, but for readability and modifiability
reasons that's the approach I take.

			regards, tom lane