Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m2uMo-0006Ay-LN for pgsql-hackers@arkaria.postgresql.org; Mon, 12 Jul 2021 11:44:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1m2uMm-0007lu-Dy for pgsql-hackers@arkaria.postgresql.org; Mon, 12 Jul 2021 11:44:52 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m2uMm-0007ll-64 for pgsql-hackers@lists.postgresql.org; Mon, 12 Jul 2021 11:44:52 +0000 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1m2uMh-0001eA-4n for pgsql-hackers@lists.postgresql.org; Mon, 12 Jul 2021 11:44:51 +0000 Received: by mail-ed1-x535.google.com with SMTP id ee25so9339897edb.5 for ; Mon, 12 Jul 2021 04:44:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hoxrc6Zo3ydp3Hg6u4eBx6HGet7LFJMsWRgzqBHbr2c=; b=smTq7iZIlyhmkPCvTmCHs666xNbryqIcnp78qw18cq4bV7DvvbrWyIoB/yH+NvJag7 coX3+A+5+8NO3SWh0GyrJwP7lPeifv3LzCNAat4k/7xVKOMRklafDozVn4wErxWkHhZ8 cMi4p75ODuR0ij5VE2HicJdrDUFWjYB58BKuxqFq//01B5tquZVSoO5zeA80YuNB/8t8 SNHIlUrNtPv/yGB+6EnfENAXz5gOP5OBVVGnjw7MQdn2BsLfDnC2iYSAgEilDDCXgne2 lnbdSrD7iKXjBpVaDTaiAyZNIMlr3k/QbxOsdRfWMiXXsYDLKkBFbJKvQXJG8Qg8tP5i kSlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hoxrc6Zo3ydp3Hg6u4eBx6HGet7LFJMsWRgzqBHbr2c=; b=r0XsuAbllVbyJeok9a3dtJ2l/iwjKlT4+26/DA/R7XmXH7Py4DtwJOENL+r+hRnjxe 9GhekCz5J93SkAtPBJMlEclLeUkZykbRUvO6HidKm4pKhtSPr58EcgK0g9M4OC63aaGl MQS/PmqwVHJwEwrJKErQtSXXUMhoem5iCqKzOm+qrHc8zjlKpEMjUF+O+Aiz255fFAVK 4ABHz86VPe4ryonmDH0+ZEHfAja9K5oluTzuBFudNDbeaiiX0iBRE7OpSDDMMnSlTnD8 n1mgaqOaAnrpyqtsUP0cBa5xfE+aUt30830GS8AwUvIO64XiSqeH3ob1nehZKsjZ0AuW /7Vg== X-Gm-Message-State: AOAM530Sz/33kTUFqoNw3C6F5iKJLULx5Y8YfU+eQIcMXdOVzWRBY0YE RxOFy0kyIumffhHMp5FMdMWWit/Y8cvwiHoyAeLXNzpaUp/Nvn/TRNOoeVD3Nd3oJPeDDlgT6Lp whsreEmKYwYjv/iwJw9Szkmh9ibEIyHm9feLn0FQbVxA0EfH/S/jvAgjChiIgE4V4ShD023CBZz 4tgYbNnfVjWeCZzs6BkdlOGsZ15S9UaV7u++1OtW0Xe/84Eu/opzwSem6QWZA2kzBqW65P27AE2 Csa4HSbDWtYeBgPDTJEjMl7C4vvBmPMb5TaVH7K7hJ9ozpwlAjOYg== X-Google-Smtp-Source: ABdhPJz8etc3EMfYp0egqmAeMwTQSSivNswAZDk88Hg0Avr6GonIQZaUB1tMVBrwIS8X5Ypb2yh20g== X-Received: by 2002:a05:6402:31a6:: with SMTP id dj6mr23652061edb.248.1626090285564; Mon, 12 Jul 2021 04:44:45 -0700 (PDT) Received: from [10.137.0.19] (ip-86-49-254-183.net.upcbroadband.cz. [86.49.254.183]) by smtp.gmail.com with ESMTPSA id s12sm7589964edd.68.2021.07.12.04.44.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jul 2021 04:44:44 -0700 (PDT) Subject: Re: row filtering for logical replication To: Euler Taveira , Greg Nancarrow Cc: Amit Kapila , Peter Smith , Rahila Syed , Peter Eisentraut , =?UTF-8?B?w5ZuZGVyIEthbGFjxLE=?= , japin , Michael Paquier , David Steele , Craig Ringer , Tomas Vondra , Amit Langote , PostgreSQL Hackers References: <7e4b5c48-a3d3-4b7e-b455-2d50c60a0ab7@www.fastmail.com> <57373e8b-1264-cd37-404e-8edbcf7884cc@enterprisedb.com> <86d76e89-9a96-411a-8077-f8918cbae2e1@www.fastmail.com> <3dbf7241-a417-45c9-9a0e-04a079de9b9f@www.fastmail.com> <0ca5b27f-edf8-4ef9-a9e2-533216890f62@www.fastmail.com> <34b61db2-3e26-42ed-bb84-b14a9fe0a60d@www.fastmail.com> <849ee491-bba3-c0ae-cc25-4fce1c03f105@enterprisedb.com> From: Tomas Vondra Message-ID: <513ffc6c-f8da-a889-9fc7-a7d9499cd72c@enterprisedb.com> Date: Mon, 12 Jul 2021 13:44:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <849ee491-bba3-c0ae-cc25-4fce1c03f105@enterprisedb.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk While looking at the other logrep patch [1] (column filtering) I noticed Alvaro's comment regarding a new parsenode (PublicationTable) not having read/out/equal/copy funcs. I'd bet the same thing applies here, so perhaps see if the patch needs the same fix. [1] https://www.postgresql.org/message-id/202107062342.eq6htmp2wgp2%40alvherre.pgsql -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company