From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: pgsql-hackers@lists.postgresql.org, Robert Haas <robertmhaas@gmail.com>,
        Thomas Munro <thomas.munro@gmail.com>
Subject: Re: Pointer subtraction with a null pointer
In-reply-to: <20220326163441.qzpcioycozbzarsf@alap3.anarazel.de>
References: <48826.1648310694@sss.pgh.pa.us> <49360.1648311192@sss.pgh.pa.us>
 <20220326163441.qzpcioycozbzarsf@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Sat, 26 Mar 2022 09:34:41 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <51677.1648312664.1@sss.pgh.pa.us>
Date: Sat, 26 Mar 2022 12:37:44 -0400
Message-ID: <51678.1648312664@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/51678.1648312664%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2022-03-26 12:13:12 -0400, Tom Lane wrote:
>> This code is old, but mylodon wasn't doing that a week ago, so
>> Andres must've updated the compiler and/or changed its options.

> Yep, updated it to clang 13. It's a warning present in 13, but not in 12.

OK, that answers that.

After more thought I agree that replacing these relptr_store calls
with something else would be the better solution.  I'll prepare a
patch.

			regards, tom lane