Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oe65O-0001VO-R6 for pgsql-hackers@arkaria.postgresql.org; Fri, 30 Sep 2022 02:49:10 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oe65N-0000n5-Dp for pgsql-hackers@arkaria.postgresql.org; Fri, 30 Sep 2022 02:49:09 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oe65N-0000kT-3u for pgsql-hackers@lists.postgresql.org; Fri, 30 Sep 2022 02:49:09 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oe65H-00028U-RX for pgsql-hackers@postgresql.org; Fri, 30 Sep 2022 02:49:08 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 28U2n0ud517852; Thu, 29 Sep 2022 22:49:00 -0400 From: Tom Lane To: Kyotaro Horiguchi cc: bdrouvot@amazon.com, sawada.mshk@gmail.com, ashutosh.bapat.oss@gmail.com, pgsql-hackers@postgresql.org Subject: Re: more descriptive message for process termination due to max_slot_wal_keep_size In-reply-to: <20220930.111519.865126851436936262.horikyota.ntt@gmail.com> References: <4035599.1664397037@sss.pgh.pa.us> <20220929.142753.315697893156649963.horikyota.ntt@gmail.com> <332715.1664472660@sss.pgh.pa.us> <20220930.111519.865126851436936262.horikyota.ntt@gmail.com> Comments: In-reply-to Kyotaro Horiguchi message dated "Fri, 30 Sep 2022 11:15:19 +0900" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <517850.1664506140.1@sss.pgh.pa.us> Date: Thu, 29 Sep 2022 22:49:00 -0400 Message-ID: <517851.1664506140@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Kyotaro Horiguchi writes: > By the way, I didn't notice at that time (and forgot about the > policy), but the HINT message has variations differing only by the > variable name. > What do you think about the attached? Hmm, maybe, but a quick grep for 'You might need to increase' finds about a dozen other cases, and none of them are using %s. If we do this we should change all of them, and they probably need "translator:" hints. I'm not sure whether abstracting away the variable names will make translation harder. regards, tom lane