Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1UftMq-000087-GS for pgsql-hackers@arkaria.postgresql.org; Fri, 24 May 2013 14:53:16 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.72) (envelope-from ) id 1UftMp-0006Ph-SG for pgsql-hackers@arkaria.postgresql.org; Fri, 24 May 2013 14:53:15 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1UftMo-0006PM-T5 for pgsql-hackers@postgreSQL.org; Fri, 24 May 2013 14:53:14 +0000 Received: from 99-153-64-76.uvs.austtx.sbcglobal.net ([99.153.64.76] helo=noel.decibel.org) by magus.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1UftMg-0002Qc-5Y for pgsql-hackers@postgreSQL.org; Fri, 24 May 2013 14:53:09 +0000 Received: from decina.local (unknown [137.122.64.58]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by noel.decibel.org (Postfix) with ESMTPSA id 3789D6D489; Fri, 24 May 2013 14:53:00 +0000 (UTC) Message-ID: <519F7EC6.4050703@nasby.net> Date: Fri, 24 May 2013 09:52:54 -0500 From: Jim Nasby User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Amit Kapila CC: 'PostgreSQL-development' Subject: Re: Move unused buffers to freelist References: <002f01ce50a8$e057c7a0$a10756e0$@kapila@huawei.com> In-Reply-To: <002f01ce50a8$e057c7a0$a10756e0$@kapila@huawei.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-Pg-Spam-Score: -0.9 (/) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On 5/14/13 8:42 AM, Amit Kapila wrote: > In the attached patch, bgwriter/checkpointer moves unused (usage_count =0 && refcount = 0) buffer’s to end of freelist. I have implemented a new API StrategyMoveBufferToFreeListEnd() to > > move buffer’s to end of freelist. > Instead of a separate function, would it be better to add an argument to StrategyFreeBuffer? ISTM this is similar to the other strategy stuff in the buffer manager, so perhaps it should mirror that... -- Jim C. Nasby, Data Architect jim@nasby.net 512.569.9461 (cell) http://jim.nasby.net -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers