Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1UpJF4-0007J6-Jq for pgsql-hackers@arkaria.postgresql.org; Wed, 19 Jun 2013 14:20:10 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.80) (envelope-from ) id 1UpJF3-0005Nn-VR for pgsql-hackers@arkaria.postgresql.org; Wed, 19 Jun 2013 14:20:10 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1UpJF2-0005Nd-QI for pgsql-hackers@postgresql.org; Wed, 19 Jun 2013 14:20:08 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by magus.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1UpJEz-0005CT-UW for pgsql-hackers@postgresql.org; Wed, 19 Jun 2013 14:20:08 +0000 Received: from mfilter18-d.gandi.net (mfilter18-d.gandi.net [217.70.178.146]) by relay3-d.mail.gandi.net (Postfix) with ESMTP id 58298A80BE; Wed, 19 Jun 2013 16:19:42 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mfilter18-d.gandi.net Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by mfilter18-d.gandi.net (mfilter18-d.gandi.net [10.0.15.180]) (amavisd-new, port 10024) with ESMTP id 2bzrAF7SwNCn; Wed, 19 Jun 2013 16:19:40 +0200 (CEST) X-Originating-IP: 98.27.58.255 Received: from [192.168.10.146] (cpe-098-027-058-255.nc.res.rr.com [98.27.58.255]) (Authenticated sender: adsend@dunslane.net) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id D7EFCA80F0; Wed, 19 Jun 2013 16:19:38 +0200 (CEST) Message-ID: <51C1BDF9.5010004@dunslane.net> Date: Wed, 19 Jun 2013 10:19:37 -0400 From: Andrew Dunstan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Peter Eisentraut CC: cedric@2ndquadrant.com, pgsql-hackers@postgresql.org, Craig Ringer Subject: Re: Bugfix and new feature for PGXS References: <201306181552.36673.cedric@2ndquadrant.com> <1371610091.13762.20.camel@vanquo.pezone.net> <201306191155.13232.cedric@2ndquadrant.com> <51C1BB02.8050908@gmx.net> In-Reply-To: <51C1BB02.8050908@gmx.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On 06/19/2013 10:06 AM, Peter Eisentraut wrote: > On 6/19/13 5:55 AM, C=C3=A9dric Villemain wrote: >> Le mercredi 19 juin 2013 04:48:11, Peter Eisentraut a =C3=A9crit : >>> On Tue, 2013-06-18 at 15:52 +0200, C=C3=A9dric Villemain wrote: >>>> This allows for example to install hstore header and be able to >>>> include them >>>> >>>> in another extension like that: >>>> # include "contrib/hstore/hstore.h" >>> That's not going to work. hstore's header file is included as #include >>> "hstore.h" (cf. hstore source code). Having it included under different >>> paths in different contexts will be a mess. >> OK. >> At the beginning I though of putting headers in include/contrib but fear= ed >> that some header may have the same name. >> If you think that it is suitable, I can do that ? (and include the clean: >> recipe that I missed on the first shot) > I don't think there is any value in moving the contrib header files aroun= d. > > > What are they going to be used for anyway? I rubbed up against this not=20 too long ago. Things will blow up if you use stuff from the module and=20 the module isn't already loaded. cheers andrew --=20 Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers