Message-ID: <51C8C5B2.6080609@dunslane.net>
Date: Mon, 24 Jun 2013 18:18:26 -0400
From: Andrew Dunstan <andrew@dunslane.net>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:17.0) Gecko/20130110 Thunderbird/17.0.2
MIME-Version: 1.0
To: cedric@2ndquadrant.com
CC: pgsql-hackers@postgresql.org, Craig Ringer <craig@2ndquadrant.com>
Subject: Re: Bugfix and new feature for PGXS
References: <201306181552.36673.cedric@2ndquadrant.com>
 <51C88483.7090900@dunslane.net> <201306242202.04162.cedric@2ndquadrant.com>
In-Reply-To: <201306242202.04162.cedric@2ndquadrant.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


On 06/24/2013 04:02 PM, C=C3=A9dric Villemain wrote:


>
> WIth extension, we do have to set VPATH explicitely if we want to use VPA=
TH
> (note that contribs/extensions must not care that postgresql has been bui=
lt
> with or without VPATH set). My patches try to fix that.


No, this is exactly what I'm objecting to. I want to be able to do:

    invoke_vpath_magic
    standard_make_commands_as_for_non_vpath

Your patches have been designed to overcome your particular issues, but=20
they don't meet the general case, IMNSHO. This is why I want to have=20
more discussion about how vpath builds could work for PGXS modules.

>
> So the point is to be able to do exactly that :
>
> $ mkdir /tmp/json_build && cd /tmp/json_build
> $ make USE_PGXS=3D1 -f /path/to/json_build/Makefile


It doesn't work:

    [andrew@emma vpath.json_build]$ PATH=3D../../inst.vpgxs.5706/bin:$PATH
    make -f `pwd`/../json_build/Makefile
    grep: json_build.control: No such file or directory
    grep: json_build.control: No such file or directory
    grep: json_build.control: No such file or directory
    grep: json_build.control: No such file or directory
    grep: json_build.control: No such file or directory
    grep: json_build.control: No such file or directory
    grep: json_build.control: No such file or directory
    grep: json_build.control: No such file or directory
    grep: json_build.control: No such file or directory
    grep: json_build.control: No such file or directory
    grep: json_build.control: No such file or directory
    gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith
    -Wdeclaration-after-statement -Wendif-labels
    -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing
    -fwrapv -fexcess-precision=3Dstandard -g -fpic -shared -o
    json_build.so  -L/home/pgl/npgl/inst.vpgxs.5706/lib -Wl,--as-needed
    -Wl,-rpath,'/home/pgl/npgl/inst.vpgxs.5706/lib',--enable-new-dtags
    cp
    /home/andrew/pgl/extns/vpath.json_build/../json_build/sql/json_build.sql
    sql/json_build--.sql
    cp: cannot create regular file `sql/json_build--.sql': No such file
    or directory
    make: *** [sql/json_build--.sql] Error 1
    [andrew@emma vpath.json_build]$


cheers

andrew


--=20
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers