Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1UrV1o-0008GR-SU for pgsql-hackers@arkaria.postgresql.org; Tue, 25 Jun 2013 15:19:33 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.80) (envelope-from ) id 1UrV1o-0000m5-4U for pgsql-hackers@arkaria.postgresql.org; Tue, 25 Jun 2013 15:19:32 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1UrV1m-0000lp-N9 for pgsql-hackers@postgresql.org; Tue, 25 Jun 2013 15:19:30 +0000 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by magus.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1UrV1Y-0005Nw-R8 for pgsql-hackers@postgresql.org; Tue, 25 Jun 2013 15:19:22 +0000 Received: from mfilter24-d.gandi.net (mfilter24-d.gandi.net [217.70.178.152]) by relay4-d.mail.gandi.net (Postfix) with ESMTP id AEED817208C; Tue, 25 Jun 2013 17:18:55 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mfilter24-d.gandi.net Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by mfilter24-d.gandi.net (mfilter24-d.gandi.net [10.0.15.180]) (amavisd-new, port 10024) with ESMTP id GXiEf5eoMegY; Tue, 25 Jun 2013 17:18:54 +0200 (CEST) X-Originating-IP: 98.27.58.255 Received: from [192.168.10.146] (cpe-098-027-058-255.nc.res.rr.com [98.27.58.255]) (Authenticated sender: adsend@dunslane.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 618131720CF; Tue, 25 Jun 2013 17:18:53 +0200 (CEST) Message-ID: <51C9B4DB.8000007@dunslane.net> Date: Tue, 25 Jun 2013 11:18:51 -0400 From: Andrew Dunstan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: cedric@2ndquadrant.com CC: pgsql-hackers@postgresql.org, Craig Ringer Subject: Re: Bugfix and new feature for PGXS References: <201306181552.36673.cedric@2ndquadrant.com> <201306242202.04162.cedric@2ndquadrant.com> <51C8C5B2.6080609@dunslane.net> <201306250124.54610.cedric@2ndquadrant.com> In-Reply-To: <201306250124.54610.cedric@2ndquadrant.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On 06/24/2013 07:24 PM, C=C3=A9dric Villemain wrote: > Le mardi 25 juin 2013 00:18:26, Andrew Dunstan a =C3=A9crit : >> On 06/24/2013 04:02 PM, C=C3=A9dric Villemain wrote: >>> WIth extension, we do have to set VPATH explicitely if we want to use >>> VPATH (note that contribs/extensions must not care that postgresql has >>> been built with or without VPATH set). My patches try to fix that. >> No, this is exactly what I'm objecting to. I want to be able to do: >> >> invoke_vpath_magic >> standard_make_commands_as_for_non_vpath >> >> Your patches have been designed to overcome your particular issues, but >> they don't meet the general case, IMNSHO. This is why I want to have >> more discussion about how vpath builds could work for PGXS modules. > The patch does not restrict anything, it is not supposed to lead to > regression. > The assignment of VPATH and srcdir are wrong in the PGXS case, the patch > correct them. You're still free to do "make VPATH=3D/mypath ..." the VPATH > provided won't be erased by the pgxs.mk logic. I still think this is premature. I have spent some more time trying to=20 make it work the way I think it should, so far without success. I think=20 we need more discussion about how we'd like VPATH to work for PGXS=20 would. There's no urgency about this - we've lived with the current=20 situation for quite a while. When I have more time I will work on it some more. cheers andrew --=20 Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers