Message-ID: <51CC4A44.2080905@gmail.com>
Date: Thu, 27 Jun 2013 16:20:52 +0200
From: Antonin Houska <antonin.houska@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:17.0) Gecko/20130510 Thunderbird/17.0.6
MIME-Version: 1.0
To: pgsql-hackers@postgresql.org
Subject: Re: GIN improvements part 1: additional information
References: 
 <CAPpHfduxv-iL7aedwPW0W5fXrWGAKfxijWM63_hZujaCRxnmFQ@mail.gmail.com>
 <CAPpHfduQrtC4B+MC9_z3QB8oJsK1Ws-H8ivEsy_cmDnfoJqkeQ@mail.gmail.com>
 <CAPpHfdszEJhSynTPX6=tB3aKq1EA1JXpwx4xiFYM097K7PhQLA@mail.gmail.com>
 <CAPpHfdu8=5spaS7c9mxwH7bNMDR6n378fZCv6c2Y3YM7iE5KiQ@mail.gmail.com>
In-Reply-To: 
 <CAPpHfdu8=5spaS7c9mxwH7bNMDR6n378fZCv6c2Y3YM7iE5KiQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 06/25/2013 12:03 AM, Alexander Korotkov wrote:
>
>
> New revision of patch is attached. Now it includes some docs.
>
>

Hi,
I was curious about the new layout of the data page, so I spent a while 
looking into the code.
It's interesting, but I suspect 2 things are not o.k.:

* gindatapage.c:dataIsEnoughSpace() - 'i++' in the for loop should 
probably be 'j++', otherwise it loops forever

* gin_private.h:ginDataPageLeafRead() - fetch_att() is used to retrieve 
the additional info, but per the definition and comments in tupmacs.h it 
expects aligned pointer.

* gindatapage.c:ginCheckPlaceToDataPageLeaf() -  comment "if leaf data 
page" should probably be "on a leaf data page" or so.

Regards,
Antonin Houska (Tony)


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers