Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1Ut07I-00011J-Rx for pgsql-hackers@arkaria.postgresql.org; Sat, 29 Jun 2013 18:43:25 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.80) (envelope-from ) id 1Ut07I-0004kc-B3 for pgsql-hackers@arkaria.postgresql.org; Sat, 29 Jun 2013 18:43:24 +0000 Received: from makus.postgresql.org ([2001:4800:7903:4::125]) by malur.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1Ut07G-0004kU-FM for pgsql-hackers@postgresql.org; Sat, 29 Jun 2013 18:43:22 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by makus.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1Ut079-0006Wt-Ri for pgsql-hackers@postgresql.org; Sat, 29 Jun 2013 18:43:21 +0000 Received: from mfilter13-d.gandi.net (mfilter13-d.gandi.net [217.70.178.141]) by relay3-d.mail.gandi.net (Postfix) with ESMTP id 1E673A80B4; Sat, 29 Jun 2013 20:42:44 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mfilter13-d.gandi.net Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by mfilter13-d.gandi.net (mfilter13-d.gandi.net [10.0.15.180]) (amavisd-new, port 10024) with ESMTP id a6OObS2YjDDO; Sat, 29 Jun 2013 20:42:42 +0200 (CEST) X-Originating-IP: 98.27.58.255 Received: from [192.168.10.146] (cpe-098-027-058-255.nc.res.rr.com [98.27.58.255]) (Authenticated sender: adsend@dunslane.net) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id B10D3A80C0; Sat, 29 Jun 2013 20:42:41 +0200 (CEST) Message-ID: <51CF2A9E.9030902@dunslane.net> Date: Sat, 29 Jun 2013 14:42:38 -0400 From: Andrew Dunstan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: cedric@2ndquadrant.com CC: pgsql-hackers@postgresql.org, Craig Ringer Subject: Re: Bugfix and new feature for PGXS References: <201306181552.36673.cedric@2ndquadrant.com> <51CB0011.8020506@dunslane.net> <51CF1F6D.8020209@dunslane.net> <201306292027.58057.cedric@2ndquadrant.com> In-Reply-To: <201306292027.58057.cedric@2ndquadrant.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Pg-Spam-Score: 0.1 (/) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On 06/29/2013 02:27 PM, C=C3=A9dric Villemain wrote: >> >> I haven't seen a response to this. One thing we are missing is >> documentation. Given that I'm inclined to commit all of this (i.e. >> cedric's patches 1,2,3, and 4 plus my addition). > I did so I sent the mail again. I believe your addition need some changes= to > allow the PGXS+VPATH case as it currently depends on the source-tree too= l. So > it needs to be in postgresql-server-devel packages, thus installed by > postgresql "make install". > I'm going to update the doc. It's probably worth to have some examples. I think we can survive for now without an additional tool. What I did=20 was a proof of concept, it was not intended as a suggestion that we=20 should install prep_buildtree. I am only suggesting that, in addition to=20 your changes, if USE_VPATH is set then that path is used instead of a=20 path inferred from the name of the Makefile. A tool to set up a full vpath build tree for extensions or external=20 modules seems to be beyond the scope of this. > >> I'm also inclined to backpatch it, since without that it seems to me >> unlikely packagers will be able to make practical use of it for several >> years, and the risk is very low. > Yes, it is valuable to help packagers here, thanks. cheers andrew --=20 Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers