Message-ID: <51D1EEEF.1030109@dunslane.net>
Date: Mon, 01 Jul 2013 17:04:47 -0400
From: Andrew Dunstan <andrew@dunslane.net>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:17.0) Gecko/20130110 Thunderbird/17.0.2
MIME-Version: 1.0
To: Peter Eisentraut <peter_e@gmx.net>
CC: cedric@2ndquadrant.com, pgsql-hackers@postgresql.org,
 Craig Ringer <craig@2ndquadrant.com>
Subject: Re: Bugfix and new feature for PGXS
References: <201306181552.36673.cedric@2ndquadrant.com>
 <201306250124.54610.cedric@2ndquadrant.com> <51C9B4DB.8000007@dunslane.net>
 <201306251729.47025.cedric@2ndquadrant.com> <51CB0011.8020506@dunslane.net>
 <51CF1F6D.8020209@dunslane.net> <51D1E8F2.4080204@gmx.net>
In-Reply-To: <51D1E8F2.4080204@gmx.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


On 07/01/2013 04:39 PM, Peter Eisentraut wrote:
> On 6/29/13 1:54 PM, Andrew Dunstan wrote:
>> I haven't seen a response to this. One thing we are missing is
>> documentation. Given that I'm inclined to commit all of this (i.e.
>> cedric's patches 1,2,3, and 4 plus my addition).
> Could someone post an updated set of patches that is currently under
> consideration?


See what I actually committed today.


>
>> I'm also inclined to backpatch it, since without that it seems to me
>> unlikely packagers will be able to make practical use of it for several
>> years, and the risk is very low.
> Actually, the risk of makefile changes is pretty high, especially in
> cases involving advanced features such as vpath.  GNU make hasn't been
> as stable is one might think, lately.  We should carefully consider
> exactly which parts are worth backpatching.
>
>


These changes are fairly small and mostly non-invasive, but if I've 
broken something we should find out about it fairly quickly, I hope.

cheers

andrew


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers