Message-ID: <51ebbe6d-10ba-41c7-bfd0-c592fb29f168@gmail.com>
Date: Tue, 9 Dec 2025 16:04:37 -0600
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] O_CLOEXEC not honored on Windows - handle inheritance
 chain
To: Thomas Munro <thomas.munro@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
References: <e2b16375-7430-4053-bda3-5d2194ff1880@gmail.com>
 <CA+hUKGJS=xdaQ6iCTSgvBrf8Cm+a_ZMmDjZYhdQX_srHkhOuqA@mail.gmail.com>
 <7f6779d5-7a0e-44c5-a85f-b4ef265db766@gmail.com>
 <35f9236e-95d8-4f31-ac6b-ec54b7de4bac@gmail.com>
 <7412f694-7c57-41e5-ae37-71136070b0da@gmail.com>
 <CA+hUKGLX7t_PZjcUGm2-hL52RsKwof4F+-ENN5qc0AOBMPY1_g@mail.gmail.com>
 <ac7fe47b-0079-4711-9c58-73467b1d262a@gmail.com>
 <e3b982d0-c56e-441e-a5d5-61de571e313c@gmail.com>
 <CA+hUKGJh0a_6EP8NLh6jjQjzzg=Nm_h9HMC19-tBww7ZqQDWVg@mail.gmail.com>
 <CA+hUKGKbWCzBPYGKuoTG2_8uCvrKuoHkvpbjxLUYhPDiJHapNg@mail.gmail.com>
Content-Language: en-US
From: Bryan Green <dbryan.green@gmail.com>
In-Reply-To: 
 <CA+hUKGKbWCzBPYGKuoTG2_8uCvrKuoHkvpbjxLUYhPDiJHapNg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/51ebbe6d-10ba-41c7-bfd0-c592fb29f168%40gmail.com>
Precedence: bulk

On 12/9/2025 3:03 PM, Thomas Munro wrote:
> On Sun, Nov 30, 2025 at 1:13 PM Thomas Munro <thomas.munro@gmail.com> wrote:
>> What do you think about these improvements?  See attached.
>>
>> * moved and adjusted new comment about flag conversion to cover all
>> three flags, since it's true for all of them
>> * adjusted the comment about why we don't use SetHandleInformation()
>> to highlight that it would be (slightly) leaky
>> * removed O_DIRECT's extra definition from port.h, since it's now in
>> win32_port.h
> 
> Hearing nothing, pushed.
> 
> I realised while back-patching that REL_16_STABLE was the last release
> that also had the old Windows-only build/test machinery under
> src/tools/msvc.  It never ran all the tests anyway, and I don't think
> we'd learn anything new by adding it, given that CI uses meson on that
> branch, so I didn't worry about remembering how to adjust that for
> now.  If someone feels strongly about it, of course we can.
Well, my drafts folder had nothing but agreement in it...

Thanks,

-- 
Bryan Green
EDB: https://www.enterprisedb.com