public inbox for [email protected]
help / color / mirror / Atom feedFrom: Jeff Davis <[email protected]>
To: Corey Huinker <[email protected]>
To: Tom Lane <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: jian he <[email protected]>
Cc: Nathan Bossart <[email protected]>
Cc: Bruce Momjian <[email protected]>
Cc: Matthias van de Meent <[email protected]>
Cc: Magnus Hagander <[email protected]>
Cc: Stephen Frost <[email protected]>
Cc: Ashutosh Bapat <[email protected]>
Cc: Peter Smith <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: [email protected]
Subject: Re: Statistics Import and Export
Date: Wed, 26 Feb 2025 10:02:13 -0800
Message-ID: <[email protected]> (raw)
In-Reply-To: <CADkLM=crPjbcyvYEpKwd1hHkaSYgCtiYbN3+Zk3zoj4GrC-g3g@mail.gmail.com>
References: <sdno5atrplq5b67vcx7x6fkzevwkzojd23izbguy2yma424wmp@siwbi3ijxdxs>
<x5yo5ly5u3dhzfaq3hrzeqhju3io5zmwk4yqrkge3ywcflffck@ghbbgsfv56yb>
<[email protected]>
<blezfpeafycxlizyynwvwzh2vywmklhvfqudhicjrccu4raqpx@4ttfufowc2vo>
<[email protected]>
<CADkLM=f0a43aTd88xW4xCFayEF25g-7hTrHX_WhV40HyocsUGg@mail.gmail.com>
<[email protected]>
<CADkLM=ckXu5wzSQZ3Y_fvAaL8rZ+upZdSecBLf5FCTMj7M6T-A@mail.gmail.com>
<[email protected]>
<CADkLM=dRMC6t8gp9GVf6y6E_r5EChQjMAAh_vPyih_zMiq0zvA@mail.gmail.com>
<y2d36zf6pl3n6ni6e4ctblu3a5iazi2dycknq53h2mjvp7lto4@hhww3h2qgdrw>
<[email protected]>
<CADkLM=cG8=gde_KjGiQC_wt0K3knJCy_mwvd-sW=f=3M2eSrEg@mail.gmail.com>
<[email protected]>
<CADkLM=fZWAPyDxmHqxiJMUvrjbi2Fo1pHr+63_1d8yhStZ=sXQ@mail.gmail.com>
<[email protected]>
<CADkLM=cCJFH7DE1W+nT4uAxgEL-gOBoKMQORJTnzmoXTFw231w@mail.gmail.com>
<[email protected]>
<CADkLM=crPjbcyvYEpKwd1hHkaSYgCtiYbN3+Zk3zoj4GrC-g3g@mail.gmail.com>
On Wed, 2025-02-26 at 04:25 -0500, Corey Huinker wrote:
> 0001 - Add attnum support to attribute_statistics_update
>
> * Basically what Tom posted earlier, minus the pg_set_attribute_stats
> stuff, obviously.
Should have a couple simple tests.
And I would use two different error message wordings:
"must specify either attname or attnum"
"cannot specify both attname and attnum"
(or similar)
The "one of attname and attnum" is a bit awkward.
The new struct for pg_clear_attribute_stats() isn't great, but as
discussed we can get rid of that in a subsequent commit.
Otherwise LGTM.
> 0002 - Add attnum support to pg_dump.
>
> * Removed att_stats_arginfo
> * Folds appendRelStatsImport and appendAttStatsImport
> into dumpRelationStats
Can we add a test here, too, to check that tables dump the attname and
indexes dump the attnum?
Everything else in the file uses i_fieldname = PQfnumber(), but in this
patch you're just using raw numbers.
Some of the fields from pg_stats are NOT NULL, so we could consider
issuing a warning in that case rather than just skipping it.
And it could use a pgindent.
I ran a quick measurement and it appears within the noise of the
numbers I posted here:
https://www.postgresql.org/message-id/[email protected]
Regards,
Jeff Davis
view thread (170+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Statistics Import and Export
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox