From: Tom Lane <tgl@sss.pgh.pa.us>
To: Chao Li <li.evan.chao@gmail.com>
cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Improve hash join's handling of tuples with null join keys
In-reply-to: <659B2B36-C0FE-4642-921D-E7120E838891@gmail.com>
References: <3061845.1746486714@sss.pgh.pa.us>
 <496221.1748882849@sss.pgh.pa.us>
 <175507656113.993.1381684440543440253.pgcf@coridan.postgresql.org>
 <544D7C83-CECE-44E7-B5D7-530E9318D231@gmail.com>
 <616751.1755276726@sss.pgh.pa.us>
 <5C5EE031-F086-4353-A17A-DA563CD24DDD@gmail.com>
 <463296.1755553046@sss.pgh.pa.us>
 <659B2B36-C0FE-4642-921D-E7120E838891@gmail.com>
Comments: In-reply-to Chao Li <li.evan.chao@gmail.com>
	message dated "Tue, 19 Aug 2025 08:58:47 +0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <52162.1755988628.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sat, 23 Aug 2025 18:37:08 -0400
Message-ID: <52163.1755988628@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/52163.1755988628%40sss.pgh.pa.us>
Precedence: bulk

Bug #19030 [1] seems to be a fresh report of the problem this patch
aims to solve.  While answering that, I realized that the v2 patch
causes null-keyed inner rows to not be included in EXPLAIN ANALYZE's
report of the number of rows output by the Hash node.  Now on the
one hand, what it's reporting is an accurate reflection of the
number of rows in the hash table, which perhaps is useful.  On the
other hand, it's almost surely going to confuse users, and it's
different from the number we produced before.  Should we try to
preserve the old behavior here?  (I've not looked at what code
changes would be needed for that.)

			regards, tom lane

[1] https://www.postgresql.org/message-id/flat/19030-944dd78d7ef94c0f%40po=
stgresql.org