Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1VE0Js-0002wq-9V for pgsql-hackers@arkaria.postgresql.org; Mon, 26 Aug 2013 17:11:12 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.80) (envelope-from ) id 1VE0Jr-0008BU-H1 for pgsql-hackers@arkaria.postgresql.org; Mon, 26 Aug 2013 17:11:11 +0000 Received: from makus.postgresql.org ([2001:4800:7903:4::125]) by malur.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1VE0Jq-0008BM-7v for pgsql-hackers@postgresql.org; Mon, 26 Aug 2013 17:11:10 +0000 Received: from smtp.01.com ([199.36.142.181] helo=smtp-out-2.01.com) by makus.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1VE0Jh-0000NB-OH for pgsql-hackers@postgresql.org; Mon, 26 Aug 2013 17:11:09 +0000 Received: from localhost (localhost [127.0.0.1]) by smtp-out-2.01.com (Postfix) with ESMTP id 8947139009F; Mon, 26 Aug 2013 12:11:00 -0500 (CDT) X-Virus-Scanned: amavisd-new at smtp-out-2.01.com Received: from smtp-out-2.01.com ([127.0.0.1]) by localhost (smtp-out-2.01.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WOLdE8ZGUvUg; Mon, 26 Aug 2013 12:11:00 -0500 (CDT) Received: from smtp-out-2.01.com (localhost [127.0.0.1]) by smtp-out-2.01.com (Postfix) with ESMTP id 603553900A2; Mon, 26 Aug 2013 12:11:00 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by smtp-out-2.01.com (Postfix) with ESMTP id 4A2A33900A1; Mon, 26 Aug 2013 12:11:00 -0500 (CDT) X-Virus-Scanned: amavisd-new at smtp-out-2.01.com Received: from smtp-out-2.01.com ([127.0.0.1]) by localhost (smtp-out-2.01.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id sPj8YcisT7hb; Mon, 26 Aug 2013 12:11:00 -0500 (CDT) Received: from [172.47.23.103] (70-36-143-10.dsl.dynamic.sonic.net [70.36.143.10]) by smtp-out-2.01.com (Postfix) with ESMTPSA id E6E4D39009F; Mon, 26 Aug 2013 12:10:56 -0500 (CDT) Message-ID: <521B8C1E.9000808@agliodbs.com> Date: Mon, 26 Aug 2013 10:10:54 -0700 From: Josh Berkus Organization: PostgreSQL Experts Inc. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 MIME-Version: 1.0 To: Fujii Masao CC: Michael Paquier , Jim Nasby , Greg Stark , Hannu Krosing , Tom Lane , Andres Freund , Alvaro Herrera , PostgreSQL-development Subject: Re: pg_system_identifier() References: <5215346B.7070800@dalibo.com> <20130822134205.GC17006@awork2.anarazel.de> <52163222.9030700@agliodbs.com> <20130822155633.GF17006@awork2.anarazel.de> <14611.1377187563@sss.pgh.pa.us> <20130822161839.GG17006@awork2.anarazel.de> <20130822162019.GC10710@eldon.alvh.no-ip.org> <20130822163059.GI17006@awork2.anarazel.de> <15653.1377189456@sss.pgh.pa.us> <52177AD5.5010809@2ndQuadrant.com> <521A8985.2040509@nasby.net> In-Reply-To: X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org All, I think we've gotten a bit off the track of the proposed patch, which is designed to report the system_identifier string currently in pg_controldata, nothing more. I'm going to reverse my vote, and vote against this patch. The reason why is that I think we should instead have a function: pg_controldata(parameter text) ... which would report *all* strings in pg_controldata. Hence, you'd do instead: pg_controldata('system identifier') This will hopefully spare us from 15 patches incrementally adding all of the individual items in controldata. -- Josh Berkus PostgreSQL Experts Inc. http://pgexperts.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers